-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VSVGVQ-106 Add Projections for Statistics. #68
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1178
💛 - Coveralls |
* feature/VSVGVQ-104: VSVGVQ-104 Add unit test for serialising individual quiz. VSVGVQ-104 Remove some linefeeds. VSVGVQ-104 Missing partner and/or company is JSON is now null instead of empty string. VSVGVQ-104 correct typo VSVGVQ-104 remove QuizType, extend QuizChannel with cup VSVGVQ-104 add Company and Partner properties to Quiz
* master: (24 commits) VSVGVQ-58 Change port for Redis from 6379 to 63799 VSVGVQ-58 Ignore RedisCommand in code coverage. VSVGVQ-58 Delete the added key in redis test. VSVGVQ-58 Add restart option to redis container for test. VSVGVQ-58 Add redis image to docker compose of test environment. VSVGVQ-110 Better naming for several methods. VSVGVQ-109 update Quiz serializers to also add team as a Quiz property VSVGVQ-109 add team property to Quiz VSVGVQ-110 fix typo and phpdoc in QuizCompositionYamlRepository VSVGVQ-108 Correct naming for unit test of a team with missing id in yaml. VSVGVQ-108 Correct naming for unit test of a team with missing id in yaml. VSVGVQ-110 add QuizCompositionYamlRepository VSVGVQ-83 Theming Backend : overrides bootstrap in aparte scss file doen ipv in de bootstrap file zoals voor verlof even besproken VSVGVQ-108 fix phpdoc in TeamNormalizer VSVGVQ-108 add serializers to Team VSVGVQ-108 fix TeamYamlRepository get method and add test VSVGVQ-104 check if required parameters are passed to Quiz constructor VSVGVQ-108 add Team model and repository (WIP) VSVGVQ-58 Enable redis extension on Travis and better file layout. VSVGVQ-58 Add a test command for Redis. ... # Conflicts: # tests/Factory/ModelsFactory.php
…epository to subscribe the listeners of quiz started.
…est for DoctrineEventStore.
* master: VSVGVQ-97 Take into account category to create uuid inside question generator. VSVGVQ-97 Better code layout. VSVGVQ-97 Rename from getByYearLanguageAndCategory to getByYearAndLanguageAndCategory. VSVGVQ-97 Remove obsolete quiz composition file. VSVGVQ-97 add test for order of questions in quiz VSVGVQ-97 refactor QuizServiceTest VSVGVQ-97 add test for getting questions by year, language and category VSVGVQ-97 fix missing return type hinting VSVGVQ-97 add test for QuizService VSVGVQ-97 remove leftover class QuizComposition VSVGVQ-97 fix double parameter and forgotten variable assignment in QuizService VSVGVQ-97 move logic for picking questions fro questionsrepo to quizservice VSVGVQ-97 fix typo in namespace of QuizService and update Quiz parameters VSVGVQ-97 add QuizComposition object VSVGVQ-97 make quizParticipant separate valueobject and inject uuidfactory in quizservice VSVGVQ-97 add quizService to create quiz with randomized questions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.