avalon_slave.vhd: added support for byte enable

[fst-21]

Hello,

first of all thank you for the great and helpful work.

I have extended the avalon_slave.vhd to include the byte enable when writing the data.

With best regards,
fst-21

[LarsAsplund]

The only thing I miss is a test for byte enable in tb_avalon_slave.vhd. Currently all bits are always set:

vunit/vunit/vhdl/verification_components/test/tb_avalon_slave.vhd

Line 51 in 3292c28

signal byteenable : std_logic_vector(tb_cfg.data_width/8 -1 downto 0) := (others => '1');

[fst-21]

I have added a test and hope this is satisfactory.

[LarsAsplund]

If you move line 60-64 after the if statement you get rid of the code duplication in lines 69-73

[LarsAsplund]

Thanks for the added test. Linting failed with a trailing whitespace on line 139 in tb_avalon_slave.vhd. One final request is to remove the code duplication in avalon_slave.vhd. I made a new inline comment on that.

[fst-21]

Thanks for the tips. I have processed both points

[fst-21]

Is there anything left for me to do for a merge?

The failed test seems to be due to problems with the tools...

[LarsAsplund]

No, I think that was a glitch. Couldn't see the re-run button so I simply merged it. We'll see what happens.

[LarsAsplund]

It worked. Thanks for your contribution.