Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message not shown when using an invalid xlsx file, and unable to do further commands #2

Open
VaishakAnand opened this issue Oct 30, 2020 · 0 comments

Comments

@VaishakAnand
Copy link
Owner

Issue: Serenity does not give any form of error / warning when an invalid xlsx file (a file that does not follow the LumiNUS downloaded file formatting). We are then unable to do the add new lesson command.

Steps to reproduce:

  1. Remove the student info from the sample file and change some fields as such:

image.png

  1. Add a new tutorial group using that file, using addgrp grp/G09 path/CS2101_G09.xlsx

  2. Attempt to add a new lesson in that Tutorial group, eg addlsn grp/G09 lsn/4-2. (fails, and no error message is shown. No message at all)

  3. try to do an invalid command, eg addgrp.

  4. do step 3 again, and the error message from the previous step remains, which might be confusing.

image.png

Suggestions:

  • Perhaps the excel file could be validated first, if possible.
  • If no change is being made, then perhaps another error message could be shown (like in this case, me, the user thought that my command was incorrect and so kept retrying the command).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant