[READY] Recognise ~/.tern-config in Tern completer

[puremourning]

Fixes #277

We simply suppress the warning if we detect a .tern-project or a user's ~/.tern-config.

[puremourning]

OK so coveralls shamed me into writing a test. We already require that there is no user config, so we might as well abuse that.

[vheon]

This 👍

---

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from the review on Reviewable.io

[Valloric]

Review status: all files reviewed at latest revision, 2 unresolved discussions, all commit checks successful.

---

ycmd/tests/javascript/event_notification_test.py, line 40 [r1] (raw file):
Doesn't this mean that a ~/.tern-config file will be overwritten if a developer runs the ycmd test suite on their machine? They might have such a file because they use Tern.js.

---

ycmd/tests/javascript/event_notification_test.py, line 86 [r1] (raw file):
I see, so you check for it first... still, this isn't ideal.

How about this: instead of calling os.path.expanduser( '~/.tern-config' ) directly in the code, create a wrapper PathToGlobalTernConfig function that calls that and then mock out that function in your test.

---

Comments from the review on Reviewable.io

[Valloric]

Review status: all files reviewed at latest revision, 2 unresolved discussions.

---

ycmd/tests/javascript/event_notification_test.py, line 86 [r1] (raw file):
Or better yet, have a GlobalTernConfigExists function that returns a bool, and mock that out in tests.

In general, I've found that mocking out filesystem access for tests leads to more maintainable test code.

---

Comments from the review on Reviewable.io

[puremourning]

I have applied the mocking approach for the tests.

---

Review status: 0 of 2 files reviewed at latest revision, 2 unresolved discussions.

---

ycmd/tests/javascript/event_notification_test.py, line 40 [r1] (raw file):
Yeah, this is unfortunate. It was the only way I could think of to test the actual code without invasive patching.

---

ycmd/tests/javascript/event_notification_test.py, line 86 [r1] (raw file):
Good point. It still leads to the same amount of uncoverable code, but testing the logic is more useful than not.

---

Comments from the review on Reviewable.io

[Valloric]

Nice!

@homu r+

---

Review status: 0 of 2 files reviewed at latest revision, all discussions resolved, some commit checks failed.

---

Comments from the review on Reviewable.io

[homu]

📌 Commit 5134865 has been approved by Valloric

[homu]

⚡ Test exempted - status