-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[READY] Recognise ~/.tern-config in Tern completer #280
Conversation
OK so coveralls shamed me into writing a test. We already require that there is no user config, so we might as well abuse that. |
9d63cc2
to
48aadc1
Compare
Reviewed 2 of 2 files at r1. Comments from the review on Reviewable.io |
Review status: all files reviewed at latest revision, 2 unresolved discussions, all commit checks successful. ycmd/tests/javascript/event_notification_test.py, line 40 [r1] (raw file): ycmd/tests/javascript/event_notification_test.py, line 86 [r1] (raw file): How about this: instead of calling Comments from the review on Reviewable.io |
Review status: all files reviewed at latest revision, 2 unresolved discussions. ycmd/tests/javascript/event_notification_test.py, line 86 [r1] (raw file): In general, I've found that mocking out filesystem access for tests leads to more maintainable test code. Comments from the review on Reviewable.io |
I have applied the mocking approach for the tests. Review status: 0 of 2 files reviewed at latest revision, 2 unresolved discussions. ycmd/tests/javascript/event_notification_test.py, line 40 [r1] (raw file): ycmd/tests/javascript/event_notification_test.py, line 86 [r1] (raw file): Comments from the review on Reviewable.io |
Nice! @homu r+ Review status: 0 of 2 files reviewed at latest revision, all discussions resolved, some commit checks failed. Comments from the review on Reviewable.io |
📌 Commit 5134865 has been approved by |
⚡ Test exempted - status |
[READY] Recognise ~/.tern-config in Tern completer Fixes #277 We simply suppress the warning if we detect a `.tern-project` or a user's `~/.tern-config`. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/280) <!-- Reviewable:end -->
Fixes #277
We simply suppress the warning if we detect a
.tern-project
or a user's~/.tern-config
.