[READY] Test python 3.3 on OS X

[puremourning]

Force the use of dynamically linked python on OS X

On OS X, Python and all of its extension libraries must be built using the same shared python library. If any of them contain a statically linked libpython.a, then the global variable linkage gets broken, and you are presented with an obscure crash. We force users to link against a dynamically linked python.

Fixes ycm-core/YouCompleteMe#18 (comment).

Testing

Pyenv works fine if you specify the --enable-framework at build time (as noted above).

Also, the virtualenv bug is fixed, so bump the version to latest.

[vheon]

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

ci/travis/travis_install.osx.sh, line 8 [r1] (raw file):
personally I find this harder to read; what about making a bash function which wrap the install || outdate || upgrade and then call it as a command one package per line?

function brew_f() {
  brew install $1 || brew outdated $1 || brew upgrade $1
}

brew_f node.js
brew_f go
...
brew_f pyenv

---

Comments from the review on Reviewable.io

[vheon]

Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

ci/travis/travis_install.osx.sh, line 8 [r1] (raw file):
is brew install $1 in the function. Is it possible to edit comments on Reviewable?

---

Comments from the review on Reviewable.io

[puremourning]

Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

ci/travis/travis_install.osx.sh, line 8 [r1] (raw file):
Because most of this is non data ink. And this requires less typing.

you have to edit your comments on gihub :)

what about this:

# List of homebrew formulae to install in the order they appear"
REQUIREMENTS="node.js
              go
              ninja
              readline
              autoconf
              pkg-config
              openssl
              pyenv"


# install node, go, ninja, pyenv and dependencies
for pkg in $REQUIREMENTS; do
  # install package, or upgrade it if it is already installed
  brew install $pkg || brew outdated $pkg || brew upgrade $pkg
done

---

Comments from the review on Reviewable.io

[micbou]

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

---

build.py, line 159 [r1] (raw file):
initializes instead of initiliases

---

Comments from the review on Reviewable.io

[puremourning]

Review status: all files reviewed at latest revision, 2 unresolved discussions.

---

build.py, line 159 [r1] (raw file):
oh my. I will never get used to this new world spleling.

---

Comments from the review on Reviewable.io

[vheon]

Review status: all files reviewed at latest revision, 2 unresolved discussions.

---

ci/travis/travis_install.osx.sh, line 8 [r1] (raw file):
I like it :)

---

Comments from the review on Reviewable.io

[Valloric]

Review status: 1 of 3 files reviewed at latest revision, 4 unresolved discussions.

---

build.py, line 164 [r1] (raw file):
LOL @ citation needed :)

---

ci/travis/travis_install.osx.sh, line 14 [r1] (raw file):
I we're using pyenv in OS X as well, why not move both this and the linux pyenv setup into common config in travis_install? I had it there at one point then moved it into the Linux file because the pyenv approach didn't work on OS X. But you've now resolved that. :)

Seems like we should be able to use upstream (that is, non-brew) pyenv on both platforms.

---

ci/travis/travis_install.osx.sh, line 40 [r1] (raw file):
Why deal with virtualenv at all now that we use pyenv? After pyenv global #.#.# is used, pip installs into the pyenv dirs. No sudo needed.

---

Comments from the review on Reviewable.io

[puremourning]

Review status: 1 of 3 files reviewed at latest revision, 3 unresolved discussions.

---

ci/travis/travis_install.osx.sh, line 14 [r1] (raw file):
I'll give it a go. I went with home-brew purely because that's the setup that I tested on my own macs (and was confident would work. Again - laziness)

---

ci/travis/travis_install.osx.sh, line 40 [r1] (raw file):
All excellent points. Truth is just laziness - debugging travis scripts is seriously time consuming because travis is so slow, and I didn't want to have to debug too much stuff.

---

Comments from the review on Reviewable.io

[puremourning]

OK i have refactored out the pyenv stuff and it is all good ;)

Appveryor is not working, but i don't think i could possibly have broken that :)

---

Review status: 1 of 5 files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.

---

Comments from the review on Reviewable.io

[puremourning]

Review status: 1 of 5 files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.

---

ci/travis/travis_install.osx.sh, line 8 [r1] (raw file):
Done.

---

ci/travis/travis_install.osx.sh, line 14 [r1] (raw file):
Done.

---

ci/travis/travis_install.osx.sh, line 40 [r1] (raw file):
Done.

---

Comments from the review on Reviewable.io

[homu]

☔ The latest upstream changes (presumably f263af2) made this pull request unmergeable. Please resolve the merge conflicts.

[Valloric]

Thanks for doing this! :)

Not triggering homu because it's saying this has merge conflicts (otherwise I would).

---

Review status: 1 of 5 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

---

Comments from the review on Reviewable.io

[puremourning]

I have rebased on your PR.

---

Review status: 1 of 5 files reviewed at latest revision, 1 unresolved discussion.

---

Comments from the review on Reviewable.io

[Valloric]

Thanks!