-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[READY] Not using --release on CI when building racerd #366
Conversation
In development mode, the Reviewed 1 of 1 files at r1. Comments from the review on Reviewable.io |
3f29dd6
to
9424885
Compare
Heh, I arrogantly thought "no need to test this out locally, it's such a trivial change I can just send it out." Serves me right. Fixed now. Review status: 1 of 2 files reviewed at latest revision, all discussions resolved. Comments from the review on Reviewable.io |
9424885
to
d699db7
Compare
Reviewed 1 of 1 files at r1, 1 of 1 files at r2. Comments from the review on Reviewable.io |
Reviewed 1 of 1 files at r2. ycmd/completers/rust/rust_completer.py, line 81 [r2] (raw file): Comments from the review on Reviewable.io |
We don't use the --release flag on Travis/AppVeyor because it makes building racerd 2.5x slower and we don't care about the speed of the produced racerd.
d699db7
to
33ddf15
Compare
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed. ycmd/completers/rust/rust_completer.py, line 81 [r2] (raw file): Comments from the review on Reviewable.io |
Thanks for the reviews! :) @homu r=vheon Review status: 1 of 2 files reviewed at latest revision, 1 unresolved discussion. Comments from the review on Reviewable.io |
📌 Commit 33ddf15 has been approved by |
[READY] Not using --release on CI when building racerd We don't use the `--release` flag on Travis/AppVeyor because it makes building racerd 2.5x slower and we don't care about the speed of the produced racerd. The 2.5x slower number is from my local workstation, but I'm guessing it's similar on Travis as well. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/366) <!-- Reviewable:end -->
💔 Test failed - status |
@homu retry |
[READY] Not using --release on CI when building racerd We don't use the `--release` flag on Travis/AppVeyor because it makes building racerd 2.5x slower and we don't care about the speed of the produced racerd. The 2.5x slower number is from my local workstation, but I'm guessing it's similar on Travis as well. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/366) <!-- Reviewable:end -->
☀️ Test successful - status |
Holy crap this shaved 5 mins off the Mac builds! From ~20 to ~15. |
We don't use the
--release
flag on Travis/AppVeyor because it makes building racerd 2.5x slower and we don't care about the speed of the produced racerd.The 2.5x slower number is from my local workstation, but I'm guessing it's similar on Travis as well.