Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[READY] Not using --release on CI when building racerd #366

Merged
merged 1 commit into from
Feb 17, 2016
Merged

Conversation

Valloric
Copy link
Member

We don't use the --release flag on Travis/AppVeyor because it makes building racerd 2.5x slower and we don't care about the speed of the produced racerd.

The 2.5x slower number is from my local workstation, but I'm guessing it's similar on Travis as well.

Review on Reviewable

@micbou
Copy link
Collaborator

micbou commented Feb 16, 2016

In development mode, the racerd executable is not built in the same folder (target/debug instead of target/release). Tests are passing on Travis Linux because of the cache. What we could do is move the racerd executable to the right folder.


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from the review on Reviewable.io

@Valloric
Copy link
Member Author

Heh, I arrogantly thought "no need to test this out locally, it's such a trivial change I can just send it out." Serves me right.

Fixed now.


Review status: 1 of 2 files reviewed at latest revision, all discussions resolved.


Comments from the review on Reviewable.io

@Valloric Valloric changed the title Not using --release on CI when building racerd [READY] Not using --release on CI when building racerd Feb 16, 2016
@vheon
Copy link
Contributor

vheon commented Feb 16, 2016

:lgtm:


Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from the review on Reviewable.io

@micbou
Copy link
Collaborator

micbou commented Feb 16, 2016

:lgtm: with a minor comment.


Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


ycmd/completers/rust/rust_completer.py, line 81 [r2] (raw file):
We can remove the else since we are returning in the if branch.


Comments from the review on Reviewable.io

We don't use the --release flag on Travis/AppVeyor because it makes
building racerd 2.5x slower and we don't care about the speed of the
produced racerd.
@Valloric
Copy link
Member Author

Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


ycmd/completers/rust/rust_completer.py, line 81 [r2] (raw file):
Done.


Comments from the review on Reviewable.io

@Valloric
Copy link
Member Author

Thanks for the reviews! :)

@homu r=vheon


Review status: 1 of 2 files reviewed at latest revision, 1 unresolved discussion.


Comments from the review on Reviewable.io

@homu
Copy link
Contributor

homu commented Feb 16, 2016

📌 Commit 33ddf15 has been approved by vheon

@homu
Copy link
Contributor

homu commented Feb 16, 2016

⌛ Testing commit 33ddf15 with merge 91a57a7...

homu added a commit that referenced this pull request Feb 16, 2016
[READY] Not using --release on CI when building racerd

We don't use the `--release` flag on Travis/AppVeyor because it makes building racerd 2.5x slower and we don't care about the speed of the produced racerd.

The 2.5x slower number is from my local workstation, but I'm guessing it's similar on Travis as well.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/366)
<!-- Reviewable:end -->
@homu
Copy link
Contributor

homu commented Feb 17, 2016

💔 Test failed - status

@Valloric
Copy link
Member Author

@homu retry

@homu
Copy link
Contributor

homu commented Feb 17, 2016

⌛ Testing commit 33ddf15 with merge 28abe58...

homu added a commit that referenced this pull request Feb 17, 2016
[READY] Not using --release on CI when building racerd

We don't use the `--release` flag on Travis/AppVeyor because it makes building racerd 2.5x slower and we don't care about the speed of the produced racerd.

The 2.5x slower number is from my local workstation, but I'm guessing it's similar on Travis as well.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/366)
<!-- Reviewable:end -->
@homu
Copy link
Contributor

homu commented Feb 17, 2016

☀️ Test successful - status

@homu homu merged commit 33ddf15 into master Feb 17, 2016
@Valloric
Copy link
Member Author

Holy crap this shaved 5 mins off the Mac builds! From ~20 to ~15.

@Valloric Valloric deleted the travis-cargo branch February 18, 2016 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants