[READY] Add -include-pch flag to the list of include flags #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! @homu r+ |
|
📌 Commit 187b1ec has been approved by |
homu
added a commit
that referenced
this pull request
Feb 16, 2016
[READY] Add -include-pch flag to the list of include flags Fix issue ycm-core/YouCompleteMe#1974. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/368) <!-- Reviewable:end -->
|
💔 Test failed - status |
micbou
force-pushed
the
include-pch-flag
branch
from
187b1ec
to
5696336
Compare
|
@homu retry Reviewed 2 of 2 files at r1. Comments from the review on Reviewable.io |
|
@homu r+ Review status: Comments from the review on Reviewable.io |
all files reviewed at latest revision, all discussions resolved, all commit checks successful.
|
📌 Commit 5696336 has been approved by |
|
⚡ Test exempted - status |
homu
added a commit
that referenced
this pull request
Feb 17, 2016
[READY] Add -include-pch flag to the list of include flags Fix issue ycm-core/YouCompleteMe#1974. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/368) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue ycm-core/YouCompleteMe#1974.