[READY] CompilationDatabase now accepts unicode strings

[Valloric]

We now have tests to ensure all of py2 str/unicode and py3 bytes/str
work as params to CompilationDatabase (both the ctor and the commands
func).

Fixes #378

[vheon]

---

Reviewed 9 of 10 files at r1, 3 of 3 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

---

Comments from the review on Reviewable.io

[micbou]

Reviewed 10 of 11 files at r1, 3 of 3 files at r2, 4 of 5 files at r3.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

cpp/ycm/tests/TestUtils.h, line 38 [r1] (raw file):
Doesn't seem to be used in this PR. Will it be needed later?

---

Comments from the review on Reviewable.io

[Valloric]

Review status: 10 of 11 files reviewed at latest revision, 1 unresolved discussion.

---

cpp/ycm/tests/TestUtils.h, line 38 [r1] (raw file):
Ah, this is a leftover from a previous (and unpublished) version of this PR. Deleted. Good catch!

---

Comments from the review on Reviewable.io

[puremourning]

feel free to pull the trigger if this ready.

---

Reviewed 6 of 11 files at r1, 1 of 3 files at r2, 4 of 5 files at r3, 1 of 2 files at r4.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

cpp/ycm/PythonSupport.h, line 35 [r4] (raw file):
Minor pedantry: shouldnt doc comments start ///? Iirc from doing GetDoc, // comments aren't included in libclangs doxygen parser. Could be remembering wrong.

---

Comments from the review on Reviewable.io

[Valloric]

Thanks for the reviews everyone!

@homu r=vheon

[homu]

📌 Commit ef1dd55 has been approved by vheon

[homu]

⌛ Testing commit ef1dd55 with merge 1b5e83d...

[Valloric]

Review status: 10 of 11 files reviewed at latest revision, 1 unresolved discussion.

---

cpp/ycm/PythonSupport.h, line 35 [r4] (raw file):
Doxygen comments do start with ///, but since when do we write those? Did I miss something? :D

Anyway, changed to use triple slash.

---

Comments from the review on Reviewable.io

[homu]

☀️ Test successful - status