Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[READY] Fix Python support tests on Windows #396

Merged
merged 1 commit into from
Feb 25, 2016
Merged

[READY] Fix Python support tests on Windows #396

merged 1 commit into from
Feb 25, 2016

Conversation

micbou
Copy link
Collaborator

@micbou micbou commented Feb 25, 2016

Fix tests by using a specific compile_commands.json for Windows. Refactor them to reduce code duplication.

Review on Reviewable

@Valloric
Copy link
Member

I agree that we should have a separate compile_commands.json file for Windows support, but I'm not a fan of the test refactoring. Tests should simple be above all else; the new approach reduces some code duplication but it costs too much in code complexity.

I don't think duplicated assertion code (which are just data declarations) is a big deal. IMO it's the non-assertion boilerplate in tests that needs to be factored out, not the assertions themselves.

@micbou
Copy link
Collaborator Author

micbou commented Feb 25, 2016

It looks like CompilationDatabase_Py2Str_test and CompilationDatabase_Py3Bytes_test are identicals (both use ToBytes). Should we merge them?

Review status: 0 of 4 files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io

@Valloric
Copy link
Member

What would be a good name for both? We actually want to test two different things, native str on py2 and bytes on py3 that just so happen to be the test code (if done carefully; the b prefix is needed). Does this mean we should actually merge them, I'm not sure. I'd lean towards keeping them separate because that one test would probably have too much nuance in it.

Review status: 0 of 4 files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io

@Valloric
Copy link
Member

Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io

@micbou
Copy link
Collaborator Author

micbou commented Feb 25, 2016

Updated with a simpler approach.

Comments from the review on Reviewable.io

@Valloric
Copy link
Member

I'm sold. :) Thanks for this!

@homu r+

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io

@homu
Copy link
Contributor

homu commented Feb 25, 2016

📌 Commit 9a8b7d4 has been approved by Valloric

homu added a commit that referenced this pull request Feb 25, 2016
@homu
Auto merge of #396 - micbou:db-unicode-windows, r=Valloric
19fbcde 
[READY] Fix Python support tests on Windows

Fix tests by using a specific `compile_commands.json` for Windows. Refactor them to reduce code duplication.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/396)
<!-- Reviewable:end -->
@homu
Copy link
Contributor

homu commented Feb 25, 2016

⌛ Testing commit 9a8b7d4 with merge 19fbcde...

@homu
Copy link
Contributor

homu commented Feb 25, 2016

☀️ Test successful - status

@homu homu merged commit 9a8b7d4 into ycm-core:db-unicode Feb 25, 2016
@micbou micbou deleted the db-unicode-windows branch February 27, 2016 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@micbou @Valloric @homu