[READY] Use LIBPL variable to find Python library #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Search Python library in two directories on Unix: - the one returned by the LIBPL variable (for Python system); - the parent directory of the standard Python library modules (for pyenv). Do not search Python library through subdirectories as it can lead to find the wrong Python library (the debug version for instance).
|
Will our python deployment issues never end...
|
😭
Reviewed 1 of 1 files at r1. Comments from Reviewable |
|
📌 Commit 1254400 has been approved by |
|
⚡ Test exempted - status |
homu
added a commit
that referenced
this pull request
Jun 8, 2016
…=Valloric [READY] Use LIBPL variable to find Python library Currently, the `build.py` script may found a debug version of the Python library instead of the release version because it searches through all the subdirectories of the standard library path. See issue #518 for details. The solution suggested by @jmenashe (using `LIBPL` variable) works fine for system Python but not for `pyenv` because there is no dynamic library in the directory returned by the `LIBPL` variable. Taking this into account, we now search the Python library in a list of directories. On Windows, this list only contains one directory; the same one as before. On other platforms, it contains two directories: - the one returned by the `LIBPL` variable (for system Python); - the parent directory of the standard Python library modules (for pyenv). Closes #518. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/519) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
build.pyscript may found a debug version of the Python library instead of the release version because it searches through all the subdirectories of the standard library path. See issue #518 for details. The solution suggested by @jmenashe (usingLIBPLvariable) works fine for system Python but not forpyenvbecause there is no dynamic library in the directory returned by theLIBPLvariable.Taking this into account, we now search the Python library in a list of directories. On Windows, this list only contains one directory; the same one as before. On other platforms, it contains two directories:
LIBPLvariable (for system Python);Closes #518.
This change is