Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Counter-Strike 2 - Smokes don't render properly #3258

Closed
MacTavishAO opened this issue Sep 27, 2023 · 72 comments
Closed

Counter-Strike 2 - Smokes don't render properly #3258

MacTavishAO opened this issue Sep 27, 2023 · 72 comments
Assignees
Labels

Comments

@MacTavishAO
Copy link

MacTavishAO commented Sep 27, 2023

Your system information

  • System information from steam (Steam -> Help -> System Information) in a gist:
  • Have you checked for system updates?: [Yes/No] Yes

Please describe your issue in as much detail as possible:

Describe what you expected should happen and what did happen.
20230928000807_1

Steps for reproducing this issue:

  1. Launch the game
  2. Enter a game or start your own server
  3. Throw smokes.
@MacTavishAO MacTavishAO changed the title Counter-Strike 2 Smokes don't render properly Counter-Strike 2 - Smokes don't render properly Sep 27, 2023
@alou-S
Copy link

alou-S commented Sep 27, 2023

It might be a upstream Mesa issue, I opened an issue on Mesa 2 weeks ago : https://gitlab.freedesktop.org/mesa/mesa/-/issues/9767

They seem to say it might be a CS2 issue. ¯\_(ツ)_/¯

@MacTavishAO
Copy link
Author

cs2.mp4

Here's a video of the issue.

@Mershl
Copy link

Mershl commented Sep 27, 2023

Interesting. On mesa 23.1.7 and an 7900XTX (RDNA 3) the smoke itself is rendered properly, though it has blue edges:
image

@KeironO
Copy link

KeironO commented Sep 27, 2023

Same with

OpenGL ES profile version string: OpenGL ES 3.2 Mesa 23.0.4-0ubuntu1~22.04.1
OpenGL ES profile shading language version string: OpenGL ES GLSL ES 3.20

Using an AMD Radeon 6750XT

@Xinayder
Copy link

Xinayder commented Sep 27, 2023

Same thing happening here, took a few screenshots. I have a RX 6700 XT and I'm running CS2 on Arch.

"Arch Linux" (64 bit)
Kernel Name: Linux
Kernel Version: 6.5.4-zen2-1-zen

Driver: AMD AMD Radeon RX 6700 XT (navi22, LLVM 16.0.6, DRM 3.54, 6.5.4-zen2-1-zen)
Driver Version: 4.6 (Compatibility Profile) Mesa 23.1.8-arch1.1
OpenGL Version: 4.6

20230927233628_1

20230927234010_1

20230927233815_1

20230927233626_1

20230927233317_1

@imavlr
Copy link

imavlr commented Sep 27, 2023

Same issue here, the smokes are invisible other than some visual glitches, for me it shows up as red lines on surface edges, but other than that it might as well not be there at all.
image
The screen-space effect when you're inside smokes also has some visual glitches, but it does block vision. Got strange edge-effects again there and everything turned blue in certain positions.

The mollies and nades also looked off, but not as noticeably, here's the molly:
image

Driver: AMD AMD Radeon RX 6600 (navi23, LLVM 16.0.6, DRM 3.54, 6.5.0-1-amd64)
Driver Version: 4.6 (Compatibility Profile) Mesa 23.2.0~rc4-1

@ghost
Copy link

ghost commented Sep 27, 2023

Driver: AMD Radeon Graphics (rembrandt, LLVM 16.0.6, DRM 3.52, 6.4.15_tkg_pds)
Driver Version: 4.6 (Compatibility Profile) Mesa 23.3.0-devel
smokes.mp4

@Mershl
Copy link

Mershl commented Sep 27, 2023

Mesa 23.3.0-0 AMDGPU
smokes.mp4

Guess mesa will become THE competitive CS2 standard for the time being...
(the issue is not reproduciable on an RTX2070)

@Rosentti
Copy link

I have this similar issue, but not as extreme. Also affects window rendering.
image
image
image

AMD RX 7900XT, Arch Linux
Devices:

GPU0:
apiVersion = 1.3.246
driverVersion = 23.1.3
vendorID = 0x1002
deviceID = 0x744c
deviceType = PHYSICAL_DEVICE_TYPE_DISCRETE_GPU
deviceName = AMD Radeon RX 7900 XT (RADV GFX1100)
driverID = DRIVER_ID_MESA_RADV
driverName = radv
driverInfo = Mesa 23.1.3
conformanceVersion = 1.3.0.0
deviceUUID = 00000000-6700-0000-0000-000000000000
driverUUID = 414d442d-4d45-5341-2d44-525600000000

@iSaluki
Copy link

iSaluki commented Sep 27, 2023

I am able to reproduce a very similar issue on my AMD Radeon RX 6600 XT.

@LiamDawe
Copy link

On my 6800xt, Mesa 23.1.8 smokes mostly work fine but sometimes I see the weird blue and yellow outlines:
20230927232057_1

@MacTavishAO
Copy link
Author

AMDVLK seems to work better and gives higher fps but shader stutters are as high as 5-6 seconds.

@Calinou
Copy link

Calinou commented Sep 27, 2023

This seems to only affect AMD GPUs (possibly Intel?). I can't reproduce this on NVIDIA 535.104.05.

@Zipdox2
Copy link

Zipdox2 commented Sep 27, 2023

Screenshot from 2023-09-28 00-55-43

Window is smoked here

@alou-S
Copy link

alou-S commented Sep 27, 2023

Interesting. On mesa 23.1.7 and an 7900XTX (RDNA 3) the smoke itself is rendered properly, though it has blue edges: !

Yes its a issue that's on the recent releases of mesa. I have done a in depth bisection of the issue on the mesa issue pointing which exact commit versions cause which smoke render bugs. Most of the bugs seem to be directly related to GPL since disabling it fixes the issue.

BUT THIS ISN'T A FIX THAT YOU SHOULD BE USING. Disabling GPL will hugely tank performance and cause stutters.

@MacTavishAO
Copy link
Author

MacTavishAO commented Sep 27, 2023

Screenshot from 2023-09-28 00-55-43

Window is smoked here

I'd like to ask the following question:

I personally won't play the game at this state because it's not fair to other players and myself, but will Valve ban players for see-through smokes whilst it's them releasing the game in this state?

@kisak-valve What should players do?

@alou-S
Copy link

alou-S commented Sep 27, 2023

You may get banned if you abuse it. If you really really want to play the game without abusing this bug you have the following options:

  1. The full smoke render bug only happens in the latest 23.2 branch and doesn't occur in older versions. You could simply downgrade to the older version by your own distro's methods. There are other minor bugs in the older versions tho but not gamebreaking.

  2. To fix the minor bugs RADV_DEBUG=nogpl envar can be used which will disable GPL and hugely effect performance by causing stutters during shader compilation. It will basically be pre GPL experience.

  3. Use the AMDVLK Driver which will both have terrible performance and stuttering issues due to its inferior shader compiler and lack of GPL. Honestly option 1 is better.

Yeah option 2 and 3 are terrible so you can stick to option 1.

@MacTavishAO
Copy link
Author

  1. RADV_DEBUG=nogpl envar which will disable GPL and hugely effect performance by causing stutters during shader compilation. It will basically be pre GPL experience.

image
I've already tested it with nogpl and this is the result.

@alou-S
Copy link

alou-S commented Sep 27, 2023

  1. RADV_DEBUG=nogpl envar which will disable GPL and hugely effect performance by causing stutters during shader compilation. It will basically be pre GPL experience.

Oh my bad then it was probably an error. It probably fixes the minor issues on the older versions I will edit the comment.

@MacTavishAO
Copy link
Author

MacTavishAO commented Sep 27, 2023

Replying to #3258 (comment)

Oh, not exactly your fault. nogpl still renders something compared to default options as you see on the screenshot.

@alou-S
Copy link

alou-S commented Sep 27, 2023

Okay yeah updated the reply to reflect reality

@Zipdox2
Copy link

Zipdox2 commented Sep 27, 2023

Screenshot from 2023-09-28 01-15-38

There's not even a trace of smoke, but you can see the grenade on the ground. If I walk into it my screen does go gray.

Driver: AMD AMD Radeon RX 6700 XT (navi22, LLVM 15.0.7, DRM 3.54, 6.5.0-1-rt-amd64)
Driver Version: 4.6 (Compatibility Profile) Mesa 23.2.0~rc3-3

@Lenny003
Copy link

image
image
image

Definitely broken

"Arch Linux" (64 bit)
Kernel Version: 6.5.5-zen1-1-zen
Driver: AMD AMD Radeon RX 7900 XTX (gfx1100, LLVM 16.0.6, DRM 3.54, 6.5.5-zen1-1-zen)
Driver Version: 4.6 (Compatibility Profile) Mesa 23.3.0-devel (git-47b481cace)

@MacTavishAO
Copy link
Author

MacTavishAO commented Sep 27, 2023

I was able to launch the game on my Steam Deck in desktop mode. Smoke bug is reproducable there too. SteamOS 3.5.

For those interested:
Launching the steam directly from ~/.local/share/Steam/steam.sh allows you to play CS2 on the deck.

@Zipdox2
Copy link

Zipdox2 commented Sep 28, 2023

Valve releases game after not testing it on Linux
Sound doesn't work on Linux
Graphical glitches on Linux
Smokes don't render on Linux
Doesn't work on their own hardware

🤣

@ghost

This comment was marked as off-topic.

@MacTavishAO
Copy link
Author

I was able to launch the game on my Steam Deck in desktop mode. Smoke bug is reproducable there too. SteamOS 3.5.

For those interested: Launching the steam directly from ~/.local/share/Steam/steam.sh allows you to play CS2 on the deck.

I was able to get a video capture of the exact bug with my Steam Deck. Sorry for low quality, I was streaming the game to my desktop using Remote Play.

cs2-deck.mp4

@mackal
Copy link

mackal commented Sep 28, 2023

I'm also experiencing this issue.

Driver: AMD AMD Radeon RX 5700 XT (navi10, LLVM 17.0.1, DRM 3.54, 6.5.5-gentoo-x86_64)
Driver Version: 4.6 (Compatibility Profile) Mesa 23.2.0-rc4

@nervyalloy51
Copy link

I've got an issue that allows me to see players that are inside smoke

Archlinux,
Kernel: 6.5.5-arch1-1
GPU: AMD RX 5700XT
Driver: Mesa 23.1.8-1
Desktop: Sway

image
image
image

@danginsburg
Copy link

Update:

So hopefully by a bit later today if you use mesa before 23.2 (i.e. before commit mentioned above) we believe smokes will be correct. Hopefully we'll be able to get a RADV fix and/or workaround on 23.2 shortly.

@danginsburg
Copy link

Another update: I've got a workaround for the bug on 23.2 so hopefully when this next update ships smokes will work on that driver too.

@emko
Copy link

emko commented Sep 29, 2023

Another update: I've got a workaround for the bug on 23.2 so hopefully when this next update ships smokes will work on that driver too.

thanks, do you happen to know if updates for Linux get included here or do we just guess when the update has been release? https://www.counter-strike.net/news/updates

@MacTavishAO
Copy link
Author

From latest update patchnotes:

Fixed smokes not rendering correctly on AMD GPUs on Linux

@emko
Copy link

emko commented Sep 29, 2023

From latest update patchnotes:

Fixed smokes not rendering correctly on AMD GPUs on Linux

oh nice they include linux changes in it

@MacTavishAO
Copy link
Author

I can confirm smokes work as expected with mesa-git for me. I'm keeping it open so other linux players can chime in.
Thank you @danginsburg!

On a side note, I'm getting 40-50% of FPS I get on windows or using windows build with dxvk. Is there any word on that?

@vaxerski

This comment was marked as off-topic.

@MacTavishAO

This comment was marked as off-topic.

@vaxerski
Copy link

No clue then :/

Ontopic, I can attest to @MacTavishAO, this is fixed for me. Molotovs as well.

@JacKeTUs
Copy link

Smokes now fixed with mesa 23.2.0

@Skeletonek

This comment was marked as off-topic.

@parona-source

This comment was marked as off-topic.

@alou-S
Copy link

alou-S commented Sep 29, 2023

Smokes, Molotovs and AWP tracers seem to be rendering fine on Mesa Git

@mackal
Copy link

mackal commented Sep 29, 2023

Appears to be fixed here as well.

@ghost
Copy link

ghost commented Sep 29, 2023

The smoke bug is fixed.

This is kindof related. But, on "world smoke" I suppose. There is rendering anomalies/errors aswell.
You may need to open the video big to see it. But it is very noticeable in person.

Driver: AMD Radeon Graphics (rembrandt, LLVM 16.0.6, DRM 3.52, 6.4.15_tkg_pds) Driver Version: 4.6 (Compatibility Profile) Mesa 23.3.0-devel

kekw.mp4

@Yuri-K7
Copy link

Yuri-K7 commented Sep 29, 2023

Smoke and molotov are fixed, but now the presence of molotov produces this screen graphics corruption, on mesa 23.3.0-devel (git-d7f3fdc262) with RX 6700.
Screenshot_20230929_033554

@FuzzyQuils
Copy link

FuzzyQuils commented Sep 29, 2023

Replying to #3258 (comment)

I don't see the bug here?
If you mean the black regions in the smoke, those are actually shadows being cast through the volume.

EDIT: nvm I see the light bleed at the edges. That is weird.

@hp-pepster
Copy link

hp-pepster commented Sep 29, 2023

Replying to #3258 (comment)

Same here, current mesa-git (23.3.0_devel.178368.80a1896539b.d41d8cd-1) AND release (23.1.8) but with Radeon RX 6950 XT. Even happens with a smoke only.

@KeironO
Copy link

KeironO commented Sep 29, 2023

It has been fixed on my end.

@KeironO
Copy link

KeironO commented Sep 29, 2023

The smoke bug is fixed.

This is kindof related. But, on "world smoke" I suppose. There is rendering anomalies/errors aswell. You may need to open the video big to see it. But it is very noticeable in person.

Driver: AMD Radeon Graphics (rembrandt, LLVM 16.0.6, DRM 3.52, 6.4.15_tkg_pds) Driver Version: 4.6 (Compatibility Profile) Mesa 23.3.0-devel
kekw.mp4

I'm having the same issues, even on High.

@danginsburg
Copy link

First, thanks all for the great repro information and follows ups. Glad to hear the original issue is fixed. Regarding this:

The smoke bug is fixed.
This is kindof related. But, on "world smoke" I suppose. There is rendering anomalies/errors aswell. You may need to open the video big to see it. But it is very noticeable in person.
Driver: AMD Radeon Graphics (rembrandt, LLVM 16.0.6, DRM 3.52, 6.4.15_tkg_pds) Driver Version: 4.6 (Compatibility Profile) Mesa 23.3.0-devel
kekw.mp4

I'm having the same issues, even on High.

I'm going to close out this issue because the other issue being talked about here is the same as #3287. I believe I have a fix for that one, which will be in the next update.

@Yuri-K7
Copy link

Yuri-K7 commented Sep 30, 2023

Tested with the new update, smoke still produces this :

Screenshot_20230930_022127

@hp-pepster
Copy link

Tested with the new update, smoke still produces this :

Screenshot_20230930_022127

@kisak-valve should we open a new issue regarding that bug? I have run some more tests.

@kisak-valve
Copy link
Member

Hello @hp-pepster, yes, follow up issues should be reported separately so that they can be tracked properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests