Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL_HINT_ENABLE_STEAM_CONTROLLERS defaults to '0' instead of '1' #39

Closed
DistractionRectangle opened this issue Mar 15, 2024 · 1 comment

Comments

@DistractionRectangle
Copy link

DistractionRectangle commented Mar 15, 2024

I'm not exactly sure where to file this issue, as it's not exactly an issue with the steamlink-sdk, and it's not an issue with the public facing SDL repo (AFAIK), but an issue with the custom build of SDL that ships with the steamlink. If there's a better place to file this, let me know @slouken.

Issue: Per SDL_hints.h, SDL_HINT_ENABLE_STEAM_CONTROLLERS should default to '1', enabled. However, as experienced in a native steamlink app, moonlight, it has defaulted to disabled since its inception (user reports track the issue as appearing after build 822, which used an sdl 2.0.17 build, and near as I can tell this hint landed as part of 2.0.22). It defaults to '0', and steamlink native apps on builds after 822 can only see steam controllers if SDL_ENABLE_STEAM_CONTROLLERS=1 is explicitly set as a shell/environment variable.

As far as the public facing SDL repo goes, I can only find three commits which contain SDL_HINT_ENABLE_STEAM_CONTROLLERS, as per git log -p --all -G 'SDL_HINT_ENABLE_STEAM_CONTROLLERS':

Aside from it's presence in SDL_hints.h, there are no commits where it's ever actually referenced/used via SDL_GetHint(SDL_HINT_ENABLE_STEAM_CONTROLLERS), thus I am led to believe it's part of an downstream patchset for SDL maintained by Valve.

@slouken
Copy link
Contributor

slouken commented Mar 15, 2024

You're right, the Steam Link version of SDL defaulted that hint to "0". This is fixed for the next firmware update, thanks!

@slouken slouken closed this as completed Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants