Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use clearanceCheckMask when checking for hand overlap #533

Open
wants to merge 1 commit into
base: beta
Choose a base branch
from

Conversation

meznaric
Copy link

HandPhysics stops working after you release an item.
Note: I had my own colliders around the hand which were overlapping with HandPhysics, and therefore after first pickup, you cannot interact physically with an item anymore. There is clearanceCheckMask that I believe serves the purpose of telling which items this check should ignore.

The clearanceCheckMask is defined and can be configured, but is simply not being used when hand releases an object.

This PR uses it in what I believe was intended place.

I can confirm it's working as it solved my bug.

@zite
Copy link
Collaborator

zite commented Sep 20, 2019

How strange we missed that! Thanks for the pull. I'll integrate into the coming release.

@gazuntype
Copy link

my god! after spending the whole day wondering what the problem was, i debugged and figured out this was it. i was excited about opening a pull request only to see it's already done. please merge.

@zite zite added the Fixed in next release Fix coming in next release label Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in next release Fix coming in next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants