Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manager.Query: Return error instead of nil pointer panic when query returns no results #2

Closed
Vanclief opened this issue Jul 4, 2020 · 1 comment
Closed

Manager.Query: Return error instead of nil pointer panic when query returns no results #2

Vanclief opened this issue Jul 4, 2020 · 1 comment

Comments

@Vanclief
Copy link
Owner

Vanclief commented Jul 4, 2020

When Manager.Query is called with an invalid query or one that returns no results, it will panic with a nil pointer exception instead of returning an error.
@Vanclief
Copy link
Owner Author

Vanclief commented Jul 9, 2020

Was only happening on PG interface, should had checked for error before checking result.

Fixed in:
8364a90

@Vanclief Vanclief closed this as completed Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Vanclief