-
Notifications
You must be signed in to change notification settings - Fork 848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nginx config templating #1643
Comments
I think that can be helpful also for that Varying-Vagrant-Vagrants/vvv-utilities#18 Maybe we can think to add in the nginx config a placeholder like Or to be more easyly we can create a new folder for every position we want that scripts can put the file that want are loaded in nginx in a specific folder following the nginx rules (with an include inside the nginx file). |
Extending this to utilities is not as easy, I wouldn't hold out hope ( and it isn't needed for that PR ) |
If we do folders where put nginx configs that hook on the various part this can be used also from utilities. |
As today now there is a new folder for utilities but nothing for templates because right now is not clear what we need specifically. |
The bash implementation of mustache would be the way to go here as we are already using basic handlebar syntax with sed. This will take all environment variables from the script and template them out. |
Note that this issue is primarily aimed at site templates for the moment, any utility would need to take the work done for site templates and translate it to whatever the utility needed since a utility may have wildly differing requirements whereas a site template is a much narrower use |
I think that we can close this now @tomjn, right now is possible to add a custom nginx file. |
I think that we can close this for #2030 |
Lets close it |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
There's a few issues and PR's such as #1632 and Varying-Vagrant-Vagrants/custom-site-template#5, that add things to the nginx config via sed commands, it would make more sense to try and do a basic templating engine, so that the provisioner file only wrangles more complex things
Suggestions?
The text was updated successfully, but these errors were encountered: