Fix #1643 #1655
Fix #1643 #1655
Conversation
|
Right now this is the first part to be used by utilities so they not conflicts with sites. |
|
Ok seems that nginx works, with this utilities but also custom sites can inject rules globally to all the websites. |
| @@ -79,3 +79,5 @@ location ~ \.php$ { | |||
| # And get to serving the file! | |||
| fastcgi_index index.php; | |||
| } | |||
|
|
|||
| include /etc/nginx/custom-rules/*.conf; | |||
There was a problem hiding this comment.
My understanding is that this is included by all site nginx configs. I don't think that this is needed as a site template can already do this via vvv-nginx.conf
There was a problem hiding this comment.
I implemented this one for Varying-Vagrant-Vagrants/custom-site-template#5
But with that we cannot load on specific site, but as you said for this case is not the best solution.
I was thinking if someone want a service that can inject their own rules on a website, with this can be possible. For this idea I don't have an example now but probably is better to remove it.
|
I don't see how this fixes that issue. It provides a mechanism for utilities to add rules yes, but it doesn't simplify site templates modifying the nginx config, and I'm unsure what |
|
I'd suggest streamlining it to the utilities rules change, then using the tideways PR as a means of testing it |
|
Changes done, now is only for custom-utilities |
Summary:
#1643