Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mte90 /fix xhgui tickets #75

Merged
merged 14 commits into from
Nov 10, 2020
Merged

Mte90 /fix xhgui tickets #75

merged 14 commits into from
Nov 10, 2020

Conversation

Mte90
Copy link
Member

@Mte90 Mte90 commented Oct 28, 2020 •
edited
Loading

@Mte90 Mte90 marked this pull request as ready for review October 28, 2020 11:54
@Mte90 Mte90 requested a review from tomjn October 28, 2020 11:55
tomjn
tomjn reviewed Oct 28, 2020
View reviewed changes
tideways/provision.sh Outdated Show resolved Hide resolved
tomjn
tomjn reviewed Oct 28, 2020
View reviewed changes
tideways/provision.sh Outdated Show resolved Hide resolved
Mte90 and others added 2 commits October 28, 2020 14:31
@Mte90 @tomjn
Update tideways/provision.sh
6168d72 
Co-authored-by: Tom J Nowell <contact@tomjn.com>
@Mte90
added noroot on composer
612a2c0
glensc
glensc reviewed Oct 28, 2020
View reviewed changes
tideways/provision.sh Outdated Show resolved Hide resolved
tomjn
tomjn reviewed Oct 28, 2020
View reviewed changes
tideways/provision.sh Outdated Show resolved Hide resolved
@Mte90
Copy link
Member Author

Mte90 commented Nov 10, 2020

We need just to wait for the release of xhgui 0.16.2 that is in progress right now that will include various bugfix.
Also with this utility we will use a fixed version so there won't again incompatibilities like now of using the master branch.

@glensc
Copy link
Contributor

glensc commented Nov 10, 2020

Also with this utility we will use a fixed version so there won't again incompatibilities like now of using the master branch.

this is correct only on the first provision, see the discussion: #75 (comment)

@Mte90
Copy link
Member Author

Mte90 commented Nov 10, 2020

Now is using git clone to download a specific tag, I think that if we keep a specific version and we bump like with other utilities we have is better because we can avoid issues and do better tests when is required.

@glensc
Copy link
Contributor

glensc commented Nov 10, 2020

@Mte90 please read the linked discussion, it explains why currently it's only half baked version locking. if you don't trust me (or the code), do run the second provision and see yourself, it switches to master branch.

@Mte90
Copy link
Member Author

Mte90 commented Nov 10, 2020

Tested everything and also updates on changing the version in the case the folder exists.
Now it is working fine!

@Mte90 Mte90 requested a review from tomjn November 10, 2020 14:02
@tomjn tomjn merged commit 267c48c into master Nov 10, 2020
@Mte90 Mte90 deleted the Mte90-/fix-xhgui-tickets branch April 13, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glensc glensc glensc left review comments

@tomjn tomjn Awaiting requested review from tomjn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mte90 @glensc @tomjn