Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean move / attack code #26

Closed
VedVid opened this issue Oct 21, 2018 · 2 comments
Closed

Clean move / attack code #26

VedVid opened this issue Oct 21, 2018 · 2 comments
Labels
enhancement New feature or request low [priority] wontfix This will not be worked on

Comments

@VedVid
Copy link
Owner

VedVid commented Oct 21, 2018

For example, MoveOrAttack and Move and Attack should take similar set of arguments. But now some functions takes coordinations, other uses *Creature, etc.

@VedVid VedVid added enhancement New feature or request low [priority] labels Oct 21, 2018
@VedVid
Copy link
Owner Author

VedVid commented Nov 13, 2018

After some thinking, I'm fine with this. Passing integers like target_x and target_y to move-related functions is much more universal than passing Tile or Creature. Dev can pass position of whatever he want - tile, creature, object...

Another thing, I'm a bit less sure about, is attack. For now, player can attack only creatures, but what if we would like to implement destructible environment? I don't think that creating destructible walls as creatures with NoAI is pretty.

@VedVid
Copy link
Owner Author

VedVid commented Nov 13, 2018

Created new issue #40 to adress doubts from previous post. Now, this issue can be closed safely.

@VedVid VedVid closed this as completed Nov 13, 2018
@VedVid VedVid added the wontfix This will not be worked on label Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low [priority] wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant