Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of telemetry #53

Merged
merged 8 commits into from
Oct 23, 2021
Merged

Removal of telemetry #53

merged 8 commits into from
Oct 23, 2021

Conversation

Vexed01
Copy link
Owner

@Vexed01 Vexed01 commented Oct 23, 2021

As decided earlier, removal of telemetry/Sentry. Closes #49

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 23, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.60%.

Quality metrics Before After Change
Complexity 6.31 ⭐ 6.45 ⭐ 0.14 👎
Method Length 65.14 🙂 62.21 🙂 -2.93 👍
Working memory 8.73 🙂 8.84 🙂 0.11 👎
Quality 66.02% 🙂 65.42% 🙂 -0.60% 👎
Other metrics Before After Change
Lines 4836 4136 -700
Changed files Quality Before Quality After Quality Change
aliases/init.py 78.65% ⭐ 82.36% ⭐ 3.71% 👍
aliases/aliases.py 48.09% 😞 36.76% 😞 -11.33% 👎
anotherpingcog/init.py 73.39% 🙂 77.47% ⭐ 4.08% 👍
anotherpingcog/anotherpingcog.py 58.48% 🙂 56.45% 🙂 -2.03% 👎
beautify/init.py 78.86% ⭐ 82.56% ⭐ 3.70% 👍
beautify/beautify.py 84.57% ⭐ 86.13% ⭐ 1.56% 👍
betteruptime/init.py 73.39% 🙂 77.47% ⭐ 4.08% 👍
betteruptime/abc.py 96.51% ⭐ 96.67% ⭐ 0.16% 👍
betteruptime/betteruptime.py 83.25% ⭐ 86.83% ⭐ 3.58% 👍
betteruptime/loop.py 70.34% 🙂 73.10% 🙂 2.76% 👍
cmdlog/init.py 78.86% ⭐ 82.56% ⭐ 3.70% 👍
cmdlog/channellogger.py 82.73% ⭐ 85.39% ⭐ 2.66% 👍
cmdlog/cmdlog.py 70.60% 🙂 70.41% 🙂 -0.19% 👎
cmdlog/objects.py 60.11% 🙂 56.51% 🙂 -3.60% 👎
github/init.py 78.86% ⭐ 82.56% ⭐ 3.70% 👍
github/github.py 55.70% 🙂 52.73% 🙂 -2.97% 👎
madtranslate/init.py 78.86% ⭐ 82.56% ⭐ 3.70% 👍
madtranslate/madtranslate.py 69.91% 🙂 66.24% 🙂 -3.67% 👎
stattrack/init.py 78.65% ⭐ 82.36% ⭐ 3.71% 👍
stattrack/abc.py 93.27% ⭐ 93.49% ⭐ 0.22% 👍
stattrack/stattrack.py 55.01% 🙂 62.90% 🙂 7.89% 👍
status/init.py 73.24% 🙂 74.47% 🙂 1.23% 👍
status/core/abc.py 95.29% ⭐ 95.51% ⭐ 0.22% 👍
status/core/core.py 67.80% 🙂 68.27% 🙂 0.47% 👍
status/updateloop/updatechecker.py 51.89% 🙂 51.95% 🙂 0.06% 👍
system/init.py 78.86% ⭐ 82.56% ⭐ 3.70% 👍
system/system.py 64.07% 🙂 61.82% 🙂 -2.25% 👎
timechannel/init.py 78.86% ⭐ 82.56% ⭐ 3.70% 👍
timechannel/abc.py 93.19% ⭐ 94.18% ⭐ 0.99% 👍
timechannel/loop.py 73.62% 🙂 74.29% 🙂 0.67% 👍
timechannel/timechannel.py 69.72% 🙂 67.21% 🙂 -2.51% 👎
wol/init.py 78.86% ⭐ 82.56% ⭐ 3.70% 👍
wol/wol.py 82.22% ⭐ 82.50% ⭐ 0.28% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
github/github.py GitHub.open 23 😞 323 ⛔ 18 ⛔ 21.74% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
aliases/aliases.py Aliases.aliases 28 😞 375 ⛔ 14 😞 21.95% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
github/github.py GitHub.addlabels 16 🙂 300 ⛔ 19 ⛔ 26.72% 😞 Try splitting into smaller methods. Extract out complex expressions
status/updateloop/updatechecker.py StatusLoop._check_for_updates 24 😞 312 ⛔ 13 😞 27.07% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
cmdlog/objects.py LoggedAppCom.__str__ 12 🙂 247 ⛔ 19 ⛔ 32.31% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@Vexed01 Vexed01 added the approved I'll be implementing this soon label Oct 23, 2021
@Vexed01 Vexed01 merged commit a56b6fc into master Oct 23, 2021
@Vexed01 Vexed01 deleted the sentry-removal branch October 23, 2021 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved I'll be implementing this soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removal of telemetry
1 participant