Issue #122 - okhttp3 read+connect timeouts added #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aecio
changed the title
aecio
requested changes
Sep 14, 2017
There was a problem hiding this comment.
Hi @maqzi ,
For consistency let's use underscores in the parameter names. Also, add the following parameters and these default values for the httpclient implementation. Thanks.
# configurations for okhttp3 fetcher
crawler_manager.downloader.okhttp.connect_timeout: 30000 # 30 sec
crawler_manager.downloader.okhttp.read_timeout: 30000 # 30 sec
#/ configurations for httpclient fetcher
crawler_manager.downloader.httpclient.socket_timeout: 30000 # 30 sec
crawler_manager.downloader.httpclient.connection_timeout: 3000 # 30 sec
crawler_manager.downloader.httpclient.connection_request_timeout: 60000 # 60 sec| @@ -47,6 +47,12 @@ | |||
|
|
|||
| @JsonProperty("crawler_manager.downloader.cookies") | |||
| private List<Cookie> cookies = null; | |||
|
|
|||
| @JsonProperty("crawler_manager.downloader.connectTimeout") | |||
There was a problem hiding this comment.
Better use underscores in connectTimeout and readTimeOut to keep consistency.
aecio
approved these changes
Sep 20, 2017
|
Thanks @maqzi! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #122.