Add variable type selector to optimize API usage #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryk-dk
reviewed
Apr 4, 2024
src/language_provider.ts
Outdated
|
|
||
| const data: string[] = await this.request(url, [], urlParams); | ||
| // Convert string array to Record<string , []> | ||
| return data.reduce((ac, a) => ({ ...ac, [a]: '' }), {}); |
There was a problem hiding this comment.
from the comment i see that the Record should be Record<string , []>, but in the reduce the object is {[string]: string}. Maybe I miss something
There was a problem hiding this comment.
Yes, there's a mistake here. I checked, only keys are used everywhere, so it's more logical to leave it as string[].
| if (labelNamesQuery) { | ||
| return this.labelNamesQuery(); | ||
| return this.datasource.getTagKeys({ filters: [], timeRange }); | ||
| } | ||
|
|
||
| const labelValuesQuery = this.query.match(labelValuesRegex); | ||
| if (labelValuesQuery) { |
There was a problem hiding this comment.
i think we should check the length also
There was a problem hiding this comment.
In case of no matches, the result will be null, not an empty array.
# Conflicts: # CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add variable type selector to optimize API usage, favoring /api/v1/labels and /api/v1/label/.../values over /api/v1/series.
#144