Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Histograms compatible with Prometheus #28

Open
vearutop opened this issue Aug 10, 2021 · 2 comments
Open

Histograms compatible with Prometheus #28

vearutop opened this issue Aug 10, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@vearutop
Copy link

vearutop commented Aug 10, 2021

Documentation makes a statement on Prometheus histograms support.

Why Histogram buckets contain vmrange labels instead of le labels like in Prometheus histograms?

Buckets with vmrange labels occupy less disk space compared to Promethes-style buckets with le labels, because vmrange buckets don't include counters for the previous ranges. VictoriaMetrics provides prometheus_buckets function, which converts vmrange buckets to Prometheus-style buckets with le labels. This is useful for building heatmaps in Grafana. Additionally, its' histogram_quantile function transparently handles histogram buckets with vmrange labels.

While I appreciate the new way of exposing and storing histogram data with vmrange, the lack of of support for le histograms reduces applicability of this library.

As a developer I'm not entirely happy with standard prometheus client (for a variety of reasons from clumsy API to protobuf dependencies) and I would like to use metrics instead, but as a developer I don't have control of what kind of technology is provided by infrastructure (Prometheus, VictoriaMetrics, etc..).

Unfortunately lack of support for le histograms makes this client incompatible with Prometheus scraper/db.

Hopefully the decision about additionally supporting le histograms can be reconsidered, so that metrics works nicely with a variety of scrapers/db.

Maybe that would also help for better adoption of VictoriaMetrics as applications may have a smoother transition by integrating metrics client first and switching scraper/db technology later.

@greyireland
Copy link

+1

@greyireland
Copy link

greyireland commented Feb 7, 2023

#45 support le label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants