Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Image at top-right and Bottom left too small on mobile #23

Closed
Vin-Jex opened this issue Oct 17, 2022 · 19 comments
Closed

[Bug]: Image at top-right and Bottom left too small on mobile #23

Vin-Jex opened this issue Oct 17, 2022 · 19 comments
Assignees
Labels
bug Something isn't working EddieHub:good-first-issue good first issue Good for newcomers hacktoberfest hacktoberfest participate

Comments

@Vin-Jex
Copy link
Owner

Vin-Jex commented Oct 17, 2022

Describe the bug
I expected the longest image height to be the least height and also look good at the same time.

To Reproduce
Steps to reproduce the behaviour:

  1. Go to dentclack.vercel.app
  2. Scroll down to About Us section
  3. See error

Expected behaviour
I expected the images to be bigger than 200px at least

Screenshots
Screenshot_20221017-081353

Smartphone (please complete the following information):

  • Device: Android
  • Browser: Chrome

Additional context
Change image to an image with longer height

@Vin-Jex Vin-Jex added bug Something isn't working good first issue Good for newcomers hacktoberfest hacktoberfest participate EddieHub:good-first-issue Up for grab Available labels Oct 17, 2022
@aryanlath
Copy link

Can you describe a little what exact changes do you want so that I can work on this?

@aryanlath
Copy link

You want changes only in the mobile screen view?

@Vin-Jex
Copy link
Owner Author

Vin-Jex commented Oct 17, 2022

You want changes only in the mobile screen view?

You can change across all screen size, just want the image to be long at least.

@Vin-Jex
Copy link
Owner Author

Vin-Jex commented Oct 17, 2022

Can you describe a little what exact changes do you want so that I can work on this?

But I can't assign you to this now, I have just assign you to something else.

@Vin-Jex Vin-Jex changed the title [Bug]: <description> [Bug]: Image at top-right and Bottom left too small on mobile Oct 17, 2022
@aryanlath
Copy link

I am not able to remove that bug in the contributors file, so please assign this to me.

@Vin-Jex
Copy link
Owner Author

Vin-Jex commented Oct 17, 2022

I am not able to remove that bug in the contributors file, so please assign this to me.

Okay let me unassigned you on that one first 😂.

You didn't try enough you know??? But it is fine 😁

@aryanlath
Copy link

I tried using contributors-img but it wasn't working. However I was currently working on increasing the height of the images.

@Vin-Jex
Copy link
Owner Author

Vin-Jex commented Oct 17, 2022

Go to pexel.com and search for a doctor image, download the one with the best height and us it.

No need to spoil the image, see why communication is key 😁.
@aryanlath

@aryanlath
Copy link

Thanks for the guidance
Screenshot 2022-10-17 at 4 37 59 PM
Is this looking good to you or the image should have no padding from above and below?

@Vin-Jex
Copy link
Owner Author

Vin-Jex commented Oct 17, 2022

Thanks for the guidance
Screenshot 2022-10-17 at 4 37 59 PM
Is this looking good to you or the image should have no padding from above and below?

The padding isn't the issues, the small images size is the issue.

The fix is just simple, change the images to a bigger one.

@Grey-A
Copy link
Collaborator

Grey-A commented Oct 17, 2022

i think @pythoniclaver means we should make them take the entire row on mobile?

@Vin-Jex
Copy link
Owner Author

Vin-Jex commented Oct 17, 2022

i think @pythoniclaver means we should make them take the entire row on mobile?

That's not what I mean but it is worth trying for sure 💯💯💯

@aryanlath
Copy link

Ok thanks for your inputs!

@zmusaddique
Copy link

Hey @pythoniclaver !
Are you still looking for improvements on this?
If yes, I would like to work upon this.

@Vin-Jex
Copy link
Owner Author

Vin-Jex commented Oct 25, 2022

Hey @pythoniclaver !
Are you still looking for improvements on this?
If yes, I would like to work upon this.

Yes please, the issue haven't been resolved

@zmusaddique Should I assign you to this?

@zmusaddique
Copy link

Sure

Hey @pythoniclaver !
Are you still looking for improvements on this?
If yes, I would like to work upon this.

Yes please, the issue haven't been resolved

@zmusaddique Should I assign you to this?

Yes sure!

@zmusaddique
Copy link

image

This is how the changed mobile view looks 👆
Are you happy with it?

@Vin-Jex
Copy link
Owner Author

Vin-Jex commented Oct 26, 2022

image

This is how the changed mobile view looks 👆 Are you happy with it?

@zmusaddique sorry for the late reply, I'm been busy with work. I'm really happy with it.

Make it a pull request, I will accept and merge. Thanks 👍🙏

@Vin-Jex Vin-Jex removed the Up for grab Available label Oct 26, 2022
@zmusaddique
Copy link

@zmusaddique sorry for the late reply, I'm been busy with work. I'm really happy with it.

Make it a pull request, I will accept and merge. Thanks 👍🙏

Glad that you liked it. I've made the pull request.

Thanks @pythoniclaver for assigning ✌

@Vin-Jex Vin-Jex closed this as completed Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working EddieHub:good-first-issue good first issue Good for newcomers hacktoberfest hacktoberfest participate
Projects
None yet
Development

No branches or pull requests

4 participants