-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Image at top-right and Bottom left too small on mobile #23
Comments
Can you describe a little what exact changes do you want so that I can work on this? |
You want changes only in the mobile screen view? |
You can change across all screen size, just want the image to be long at least. |
But I can't assign you to this now, I have just assign you to something else. |
I am not able to remove that bug in the contributors file, so please assign this to me. |
Okay let me unassigned you on that one first 😂. You didn't try enough you know??? But it is fine 😁 |
I tried using contributors-img but it wasn't working. However I was currently working on increasing the height of the images. |
Go to pexel.com and search for a doctor image, download the one with the best height and us it. No need to spoil the image, see why communication is key 😁. |
i think @pythoniclaver means we should make them take the entire row on mobile? |
That's not what I mean but it is worth trying for sure 💯💯💯 |
Ok thanks for your inputs! |
Hey @pythoniclaver ! |
Yes please, the issue haven't been resolved @zmusaddique Should I assign you to this? |
Sure
Yes sure! |
@zmusaddique sorry for the late reply, I'm been busy with work. I'm really happy with it. Make it a pull request, I will accept and merge. Thanks 👍🙏 |
Glad that you liked it. I've made the pull request. Thanks @pythoniclaver for assigning ✌ |
Describe the bug
I expected the longest image height to be the least height and also look good at the same time.
To Reproduce
Steps to reproduce the behaviour:
Expected behaviour
I expected the images to be bigger than 200px at least
Screenshots
Smartphone (please complete the following information):
Additional context
Change image to an image with longer height
The text was updated successfully, but these errors were encountered: