Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: expose validators as package submodule #83

Merged
merged 3 commits into from
Mar 19, 2021

Conversation

mixvar
Copy link
Collaborator

@mixvar mixvar commented Mar 12, 2021

Screenshot 2021-03-12 at 04 16 36

mess with rollup config based on https://stackoverflow.com/a/65173887 and use some bash scripts to prepare desired npm package.

closes #73

@mixvar mixvar requested a review from pidkopajo March 12, 2021 03:17

module.exports = {
rollup(config, options) {
if (options.format === "esm") {
Copy link
Collaborator Author

@mixvar mixvar Mar 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had to choose either esm or cjs and went with esm. Not really sure which one should it be...

@mixvar
Copy link
Collaborator Author

mixvar commented Mar 17, 2021

can be tested here: https://codesandbox.io/s/jolly-mestorf-yb75o?file=/src/example.tsx via 0.1.24-beta.1 release

@mixvar mixvar merged commit 97de685 into master Mar 19, 2021
@mixvar mixvar deleted the feat/validators-submodule branch March 19, 2021 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

separate import path for validators
2 participants