Tweak package #1161
Merged
Tweak package #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexarchambault
force-pushed
the
tweak-package
branch
from
2d91b60
to
3586701
Compare
This JAR contains classes for things like 'import $ivy' to compile. These shouldn't be referenced by user classes, so are not needed at runtime.
alexarchambault
force-pushed
the
tweak-package
branch
from
3586701
to
8899122
Compare
Not sure if a particular Scala 2.12 version lifted that issue, but it sure works with the latest Scala Native and 2.12 versions.
alexarchambault
force-pushed
the
tweak-package
branch
from
8899122
to
03a03cc
Compare
lwronski
reviewed
Jul 11, 2022
...ves/src/main/scala/scala/build/preprocessing/directives/UsingPackagingDirectiveHandler.scala
Show resolved
Hide resolved
modules/cli-options/src/main/scala/scala/cli/commands/PackageOptions.scala
Show resolved
Hide resolved
modules/cli/src/main/scala/scala/cli/commands/util/PackageOptionsUtil.scala
Show resolved
Hide resolved
lwronski
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are mainly bits from #1086, that don't involve Spark.