Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn off running tests in PR for M1 runner #1403

Merged
merged 1 commit into from
Sep 29, 2022
Merged

Turn off running tests in PR for M1 runner #1403

merged 1 commit into from
Sep 29, 2022

Conversation

lwronski
Copy link
Contributor

No description provided.

alexarchambault
alexarchambault reviewed Sep 29, 2022
View reviewed changes
Copy link
Contributor

@alexarchambault alexarchambault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we restrict it to branches living on the VirtusLab organization? That way, we could run the M1 CI on our own PRs by pushing branches to VirtusLab/scala-cli rather than our own forks.

@alexarchambault
Copy link
Contributor

Wondering if users wouldn't be able to run things on the M1 machine by simply removing these two lines… 🤔

@lwronski lwronski enabled auto-merge (squash) September 29, 2022 10:55
@lwronski lwronski merged commit 165bd5a into VirtusLab:main Sep 29, 2022
@Gedochao Gedochao added the internal Internal or build-related changes label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexarchambault alexarchambault alexarchambault approved these changes

@Gedochao Gedochao Gedochao approved these changes

@wleczny wleczny Awaiting requested review from wleczny

Assignees
No one assigned
Labels
internal Internal or build-related changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lwronski @alexarchambault @Gedochao