Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update scala-packager to 0.1.29 and hardcode upgradeCodeGuid #1446

Merged
merged 2 commits into from Oct 12, 2022
Merged

Update scala-packager to 0.1.29 and hardcode upgradeCodeGuid #1446

merged 2 commits into from Oct 12, 2022

Conversation

lwronski
Copy link
Contributor

No description provided.

@lwronski lwronski linked an issue Oct 12, 2022 that may be closed by this pull request
There are many Winodws installation #1442
Closed
alexarchambault
alexarchambault approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@alexarchambault alexarchambault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT Can you move the change of ref doc in the last commit to the first one? (it belongs to this one, it's a consequence of its changes)

@lwronski lwronski merged commit d50e707 into VirtusLab:main Oct 12, 2022
@Gedochao Gedochao added the bug Something isn't working label Oct 13, 2022
@lwronski lwronski added installation Everything related to installing the CLI itself windows Windows-specific issues labels Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexarchambault alexarchambault alexarchambault approved these changes

@Gedochao Gedochao Awaiting requested review from Gedochao

@wleczny wleczny Awaiting requested review from wleczny

Assignees
No one assigned
Labels
bug Something isn't working installation Everything related to installing the CLI itself windows Windows-specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

There are many Winodws installation
3 participants
@lwronski @alexarchambault @Gedochao