Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use snapshot repo to download stubs #1693

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Use snapshot repo to download stubs #1693

merged 1 commit into from
Dec 16, 2022

Conversation

lwronski
Copy link
Contributor

No description provided.

tgodzik
tgodzik approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was there .root used actually. What does the method do on the repo? Any diea?

@lwronski
Copy link
Contributor Author

Why was there .root used actually. What does the method do on the repo? Any diea?

Some time ago I changed the argument type in the artifact methods from:

extraRepositories: Seq[String] -> extraRepositories: Seq[Repository]

so now we don't need to run root method to get plain repository name.

@lwronski lwronski merged commit 2411d62 into VirtusLab:main Dec 16, 2022
@Gedochao Gedochao added the bug Something isn't working label Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

@alexarchambault alexarchambault alexarchambault approved these changes

@Gedochao Gedochao Gedochao approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lwronski @tgodzik @alexarchambault @Gedochao