Add more interactive install-home command #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwronski
force-pushed
the
feature/install-home
branch
3 times, most recently
from
8338428
to
5e416a8
Compare
lwronski
force-pushed
the
feature/install-home
branch
2 times, most recently
from
8bffcd4
to
3c6e447
Compare
tpasternak
reviewed
Oct 6, 2021
modules/cli/src/main/scala/scala/cli/commands/AboutOptions.scala
Outdated
Show resolved
Hide resolved
modules/cli/src/main/scala/scala/cli/commands/InstallHome.scala
Outdated
Show resolved
Hide resolved
modules/integration/src/test/scala/scala/cli/integration/InstallHomeTests.scala
Outdated
Show resolved
Hide resolved
modules/cli/src/main/scala/scala/cli/commands/InstallHome.scala
Outdated
Show resolved
Hide resolved
| System.err.println("Abort") | ||
| sys.exit(1) | ||
| } | ||
| else |
There was a problem hiding this comment.
we could handle incorrect response here and ask again
There was a problem hiding this comment.
I want to make something similar to apt installer. There, if you don't accept operating with passing 'Y', it will abort process and you have to run again.
Downgrade to scala-cli should be very rarely situation and we should help user to avoid this operation. So I think, that passing any other sign then 'Y' should reject this operation.
modules/cli/src/main/scala/scala/cli/commands/InstallHome.scala
Outdated
Show resolved
Hide resolved
modules/cli/src/main/scala/scala/cli/commands/AboutOptions.scala
Outdated
Show resolved
Hide resolved
modules/cli/src/main/scala/scala/cli/commands/InstallHome.scala
Outdated
Show resolved
Hide resolved
modules/integration/src/test/scala/scala/cli/integration/InstallHomeTests.scala
Outdated
Show resolved
Hide resolved
modules/integration/src/test/scala/scala/cli/integration/InstallHomeTests.scala
Outdated
Show resolved
Hide resolved
modules/cli/src/main/scala/scala/cli/commands/InstallHome.scala
Outdated
Show resolved
Hide resolved
modules/cli/src/main/scala/scala/cli/commands/InstallHome.scala
Outdated
Show resolved
Hide resolved
modules/cli/src/main/scala/scala/cli/commands/InstallHome.scala
Outdated
Show resolved
Hide resolved
modules/cli/src/main/scala/scala/cli/commands/InstallHome.scala
Outdated
Show resolved
Hide resolved
lwronski
force-pushed
the
feature/install-home
branch
from
dc50e31
to
feed2d3
Compare
tpasternak
reviewed
Oct 11, 2021
| System.err.println( | ||
| s"Error: scala-cli is already installed $oldVersion and up-to-date. Downgrade to $newVersion pass -f or --force." | ||
| ) | ||
| sys.exit(1) |
There was a problem hiding this comment.
I'd prefer not to put exit in a function named logDowngrade. Minor issue, can be done in a follow-up PR
| ) | ||
| } | ||
|
|
||
| def runInstallHome(): Unit = { |
There was a problem hiding this comment.
Very sophisticated test, took me some time that we build fake scala-cli executables that can print only version and juggle them. Maybe we could comment it (in at all)
tpasternak
approved these changes
Oct 11, 2021
modules/cli/src/main/scala/scala/cli/commands/VersionOptions.scala
Outdated
Show resolved
Hide resolved
lwronski
force-pushed
the
feature/install-home
branch
from
0c61cb6
to
f447d89
Compare
alexarchambault
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--forceflag, we install scala-cli without any checking, if scala-cli is up-to-date.