Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comply with optional password in scala-cli-signing #1982

Merged
merged 3 commits into from Apr 3, 2023
Merged

Comply with optional password in scala-cli-signing #1982

merged 3 commits into from Apr 3, 2023

Conversation

MaciejG604
Copy link
Contributor

@MaciejG604 MaciejG604 commented Mar 29, 2023 •
edited

@MaciejG604 MaciejG604 changed the title Comply with optional password from signing Comply with optional password in scala-cli-signing Mar 29, 2023
@MaciejG604 MaciejG604 force-pushed the comply-with-optional-password-from-signing branch from 21f733f to 1b36ea6 Compare March 31, 2023 07:09
@MaciejG604 MaciejG604 force-pushed the comply-with-optional-password-from-signing branch from 1b36ea6 to c1bd87d Compare March 31, 2023 08:15
@MaciejG604 MaciejG604 self-assigned this Mar 31, 2023
@MaciejG604 MaciejG604 marked this pull request as ready for review March 31, 2023 08:17
@Gedochao
Copy link
Contributor

NIT I'd suggest some commit structure tweaks:

  • b8dbf04 and 25ffee2 could be squashed into a single commit, IMO
  • c1bd87d should have the NIT prefix in the commit message

@MaciejG604 MaciejG604 mentioned this pull request Mar 31, 2023
Merged
lwronski
lwronski approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@lwronski lwronski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaciejG604 MaciejG604 force-pushed the comply-with-optional-password-from-signing branch 2 times, most recently from f98f9e7 to f2a7d65 Compare March 31, 2023 14:59
@MaciejG604 MaciejG604 merged commit 2476332 into VirtusLab:main Apr 3, 2023
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gedochao Gedochao Gedochao left review comments

@lwronski lwronski lwronski approved these changes

Assignees

@MaciejG604 MaciejG604

Labels
publish command
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rely on a private key rather than secret key + password in publish / publish setup
3 participants
@MaciejG604 @Gedochao @lwronski