Do not lose exception in bloop connection check #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpasternak
force-pushed
the
do-not-lose-exception-in-bloop-connection-check
branch
from
3e50648
to
2f5c178
Compare
Exceptions in Operations.startServer.check0 were ignored (not passed to the promise). In case of a recurringe exception, the result presented to the user was just timeout. After this change, if timeout occurs, the method fills promise with the last, or almost last exception.
tpasternak
force-pushed
the
do-not-lose-exception-in-bloop-connection-check
branch
from
2f5c178
to
9f00216
Compare
lwronski
approved these changes
Jan 18, 2022
tpasternak
deleted the
do-not-lose-exception-in-bloop-connection-check
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.