Add missing Scala Native using directives #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes compilation mode, clang and clang++ paths, all already implemented as CLI options.
jchyb
force-pushed
the
add-missing-sn-directives
branch
from
cb5ae66
to
0c6eb91
Compare
|
If it’s passing all the tests, it would be great if it gets merged, first! |
lwronski
approved these changes
Mar 4, 2022
alexarchambault
approved these changes
Mar 6, 2022
romanowski
pushed a commit
to romanowski/scala-cli
that referenced
this pull request
Mar 10, 2022
* Add missing Scala Native using directives This includes compilation mode, clang and clang++ paths, all already implemented as CLI options. * Refactor Scala Native using directives * Remove repeating test * Add unit-tests for nativeMode using directive * Add unit-tests for clang-path and clang-path-pp * Move SN using directive tests to a separate file * Unify repeating buildOptions in ScalaNativeUsingDirectivesTests * Add missing SN using directives to docs/reference * Fix a SN using directive test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on a Scala Native related cookbook I noticed that not all SN CLI options had using directives counterparts. This PR add all 3 missing: native-mode (important in my opinion), clang and clang++ paths (not that important but added for the sake of consistency).
Since the tests for SN using directives were starting to take a fourth of all BuildTests I moved them to a separate suite (but I can revert if necessary).