Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable Scala 3 Native build, drop to Scala 3.1.3 #169

Merged
merged 2 commits into from Sep 5, 2022

Conversation

keynmol
Copy link
Contributor

@keynmol keynmol commented Sep 1, 2022

Additionally, fix errors on older Scala 3

I was hitting the following errors:

[error] -- Error: /Users/velvetbaldmime/projects/scala-yaml/core/shared/src/test/scala-3/org/virtuslab/yaml/BaseYamlEncoderSuite.scala:28:54
[error] 28 |    case class Data(int: Int, double: Double) derives YamlCodec
[error]    |                                                      ^
[error]    |undefined: YamlEncoderCrossCompanionCompat_this.deriveProduct # -1: TermRef(TermRef(NoPrefix,val YamlEncoderCrossCompanionCompat_this),deriveProduct) at inlining
[error]    |---------------------------------------------------------------------------
[error]    |Inline stack trace
[error]    |- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
[error]    |This location contains code that was inlined from YamlEncoderCrossCompat.scala:8
[error]  8 |    case p: Mirror.ProductOf[T] => deriveProduct(p)
[error]    |                                   ^^^^^^^^^^^^^
[error]     ---------------------------------------------------------------------------
[error] one error found
[error] (core / Test / compileIncremental) Compilation failed

Not sure if it's a regression on Scala 3 or what, but I think it'd be prudent to have a 3.1.x release first.

Additionally, fix errors on newer Scala 3
@keynmol keynmol changed the title Reenable Scala 3 Native build Reenable Scala 3 Native build, drop to Scala 3.1.3 Sep 1, 2022
@keynmol
Copy link
Contributor Author

keynmol commented Sep 1, 2022

@lwronski @kpodsiad whenever you have time :)

Would be good to get both a SN 3 release, but also to not have to bump to Scala 3.2.x as it's just been released and it would force upgrades.

@armanbilge
Copy link
Contributor

👍 I'm the one that bumped to Scala 3.2 and temporarily dumped Native in #162 (comment) because I obviously didn't have what it takes to power through the compile issues ... happy to see this reverted.

@lwronski
Copy link
Contributor

lwronski commented Sep 5, 2022

@keynmol LGTM, Thanks for contributing!

@lwronski lwronski merged commit 9ea7e3b into VirtusLab:main Sep 5, 2022
@armanbilge
Copy link
Contributor

Nice! Would be great if we can get a release with this soon :)

@lwronski
Copy link
Contributor

lwronski commented Sep 5, 2022

Nice! Would be great if we can get a release with this soon :)

Yea, thanks again for your contributions, scala-yaml 0.0.5 is available in maven - https://repo1.maven.org/maven2/org/virtuslab/scala-yaml_3/0.0.5/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants