Add ATSAMDA1[EGJ] support #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
intended to fix atsamd-rs#623 |
sakian
approved these changes
Aug 30, 2022
| unsafe { | ||
| // 6 here means: use 64k cycles of OSCULP32k to start up this oscillator | ||
| w.startup().bits(6); | ||
| } | ||
| #[cfg(feature = "samda1")] |
There was a problem hiding this comment.
Interesting. I wonder why the PACs are different here. Maybe the D21 SVD is an older version?
There was a problem hiding this comment.
yes, there's a few places like that. in some cases it's fresher SVD (e.g. SPIM versus SPI) and in some cases I think it's fresher svd2rust like this case?
|
so much fun with features |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added ATSAMDA1[EGJ] PAC and associated HAL updates
Checklist
CHANGELOG.mdfor the BSP or HAL updatedIf Adding a new Board
crates.json