Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(site-wide): performance enhancements #93

Merged
merged 11 commits into from
May 6, 2024

Conversation

0xRowdy
Copy link
Contributor

@0xRowdy 0xRowdy commented May 5, 2024

Overview

Overview of the changes in the PR.

Installations Needed

List out any new packages that have been added.

Desktop

VoiceDeck Initial Performance Report Desktop Home Page.pdf
VoiceDeck Initial Performance Report Desktop Report Page.pdf

After performance enhancements

VoiceDeck Final Performance Report Desktop Home Page.pdf
VoiceDeck Final Performance Report Desktop Report Page.pdf

Mobile

VoiceDeck Initial Performance Report Mobile Home Page.pdf
VoiceDeck Initial Performance Report Mobile Report Page.pdf

After performance enhancements
VoiceDeck Final Performance Report Mobile Home Page.pdf
VoiceDeck Final Performance Report Mobile Report Page.pdf

Considering adding a screenshot or screencapture of the changes.

Checks

Before making your PR, please check the following:

  • Critical lint errors are resolved
  • App runs locally
  • App builds locally (run the bun run build and resolve any errors before the PR when possible)

Copy link

render bot commented May 5, 2024

@0xRowdy 0xRowdy changed the title fix(hero-img): updated image formats to more performant modern format fix(site-wide): performance enhancements May 6, 2024
@0xRowdy 0xRowdy requested a review from CJ-Rose May 6, 2024 03:57
Copy link
Contributor

@baumstern baumstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, LGTM!

@baumstern baumstern merged commit 0006163 into main May 6, 2024
3 checks passed
@0xRowdy
Copy link
Contributor Author

0xRowdy commented May 6, 2024

Note: All performance testing was done in an incognito window to eliminate Chrome extensions from interfering with the results. Tests were completed on the production-built version of the project running on my local machine.

@baumstern baumstern mentioned this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants