Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Reset dependent variables when selecting the value #138

Merged
merged 7 commits into from
Apr 1, 2024
Merged

Add Reset dependent variables when selecting the value #138

merged 7 commits into from
Apr 1, 2024

Conversation

asimonok
Copy link
Collaborator

@asimonok asimonok commented Mar 28, 2024 •
edited by mikhail-vl
Loading

@asimonok asimonok self-assigned this Mar 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.61017% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 98.80%. Comparing base (a27247b) to head (a0529f3).

Files Patch % Lines
src/module.ts 50.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #138      +/-   ##
==========================================
- Coverage   98.94%   98.80%   -0.15%     
==========================================
  Files          54       55       +1     
  Lines        1138     1169      +31     
  Branches      280      283       +3     
==========================================
+ Hits         1126     1155      +29     
- Misses         12       14       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikhail-vl mikhail-vl added the enhancement New feature or request label Mar 28, 2024
@mikhail-vl mikhail-vl added this to the Version 2.4.0 milestone Mar 28, 2024
@mikhail-vl mikhail-vl changed the title Reset variables Add Reset dependent variables when selecting the value Mar 29, 2024
mikhail-vl
mikhail-vl approved these changes Apr 1, 2024
View reviewed changes
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mikhail-vl mikhail-vl merged commit ce09e3c into main Apr 1, 2024
3 checks passed
@mikhail-vl mikhail-vl deleted the feat/null-some-variables branch April 1, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikhail-vl mikhail-vl mikhail-vl approved these changes

Assignees

@asimonok asimonok

Labels
enhancement New feature or request
Projects
None yet
Milestone
Version 2.4.0
Development

Successfully merging this pull request may close these issues.

Allow to nullify some variables when selecting the value Clear dependent dashboard variables
4 participants
@asimonok @codecov-commenter @mikhail-vl @vitPinchuk