Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image threshold style for showing status in Table view #170

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

asimonok
Copy link
Collaborator

@asimonok asimonok commented Jul 5, 2024

Resolves #169

@asimonok asimonok requested a review from mikhail-vl July 5, 2024 12:36
@asimonok asimonok self-assigned this Jul 5, 2024
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 95.71429% with 3 lines in your changes missing coverage. Please review.

Project coverage is 98.60%. Comparing base (572e5d6) to head (d290807).

Files Patch % Lines
src/module.ts 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
- Coverage   98.69%   98.60%   -0.09%     
==========================================
  Files          60       64       +4     
  Lines        1300     1365      +65     
  Branches      337      402      +65     
==========================================
+ Hits         1283     1346      +63     
- Misses         17       18       +1     
- Partials        0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikhail-vl mikhail-vl added the enhancement New feature or request label Jul 5, 2024
@mikhail-vl mikhail-vl added this to the Version 3.2.0 milestone Jul 5, 2024
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mikhail-vl mikhail-vl merged commit bfd6e8e into main Jul 9, 2024
5 of 7 checks passed
@mikhail-vl mikhail-vl deleted the feat/status-style-image branch July 9, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: display svg instead of colored status or display both
2 participants