Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update variable option label for parent items in tree view #62

Merged
merged 2 commits into from
Aug 30, 2023

Conversation

asimonok
Copy link
Collaborator

@asimonok asimonok commented Aug 28, 2023

Resolves #61

Assumption: variable option value is always string

@asimonok asimonok self-assigned this Aug 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (aed0afd) 99.06% compared to head (06d4843) 99.06%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #62   +/-   ##
=======================================
  Coverage   99.06%   99.06%           
=======================================
  Files          50       50           
  Lines         746      748    +2     
  Branches      148      149    +1     
=======================================
+ Hits          739      741    +2     
  Misses          2        2           
  Partials        5        5           
Files Changed Coverage Δ
src/hooks/useTable.tsx 97.08% <100.00%> (+0.05%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikhail-vl mikhail-vl added the enhancement New feature or request label Aug 30, 2023
@mikhail-vl mikhail-vl added this to the Version 1.7.0 milestone Aug 30, 2023
@mikhail-vl mikhail-vl changed the title Fix showing variable option label for parent items Update variable option label for parent items in tree view Aug 30, 2023
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mikhail-vl mikhail-vl merged commit a31c02d into main Aug 30, 2023
4 checks passed
@mikhail-vl mikhail-vl deleted the feat/fix-parent-item-text branch August 30, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Variable __text is not displayed correctly, when using groups
3 participants