Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed ability to add group to favorites #88

Merged
merged 4 commits into from
Nov 8, 2023

Conversation

asimonok
Copy link
Collaborator

@asimonok asimonok commented Nov 8, 2023

Removing as not planned and missed when tested.

Resolves #76

@asimonok asimonok self-assigned this Nov 8, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2ffe5e2) 98.14% compared to head (45a130f) 98.14%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #88   +/-   ##
=======================================
  Coverage   98.14%   98.14%           
=======================================
  Files          51       51           
  Lines         862      862           
  Branches      184      184           
=======================================
  Hits          846      846           
  Misses          2        2           
  Partials       14       14           
Files Coverage Δ
src/utils/table.ts 97.75% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikhail-vl mikhail-vl added the enhancement New feature or request label Nov 8, 2023
@mikhail-vl mikhail-vl added this to the Version 2.1.0 milestone Nov 8, 2023
@mikhail-vl mikhail-vl changed the title Disallow add group to favorites Removed ability to add group to favorites Nov 8, 2023
@mikhail-vl mikhail-vl added bug Something isn't working and removed enhancement New feature or request labels Nov 8, 2023
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mikhail-vl mikhail-vl merged commit 2d000f9 into main Nov 8, 2023
4 checks passed
@mikhail-vl mikhail-vl deleted the feat/disallow-group-favoriting branch November 8, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select a group of values as favorites
3 participants