Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .close to Connection #262

Open
erny-powel opened this issue Jul 5, 2022 · 1 comment
Open

Add .close to Connection #262

erny-powel opened this issue Jul 5, 2022 · 1 comment

Comments

@erny-powel
Copy link
Collaborator

gRPC channels have a .close method that releases resources and terminates active RPCs. We should expose this as Connection.close. In addition we should make Connection a context manager that closes on exit. This mirrors the behavior of channel context managers.

@tnoczyns-volue thoughts?
@tnoczyns-volue
Copy link
Collaborator

I like it 👍 Looks like a low hanging fruit from the implementation side. More work would be to update examples and documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@erny-powel @tnoczyns-volue