Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timeout argument to methods that invoke RPCs #263

Open
erny-powel opened this issue Jul 5, 2022 · 1 comment
Open

Add timeout argument to methods that invoke RPCs #263

erny-powel opened this issue Jul 5, 2022 · 1 comment

Comments

@erny-powel
Copy link
Collaborator

gRPC supports it, and it's useful.

@tnoczyns-volue thoughts?
@erny-powel erny-powel changed the title Add timeout argument to methods that invoke RPCs. Add timeout argument to methods that invoke RPCs Jul 5, 2022
@tnoczyns-volue
Copy link
Collaborator

It is useful indeed. One of the potential approaches would be to add this timeout as an argument to Connection classes when initializing to avoid extending every single Connection and Session method that calls RPC. But I'm fine with both options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@erny-powel @tnoczyns-volue