Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot query documents without limit using multi2 #2595

Open
EloyID opened this issue Jun 29, 2020 · 1 comment
Open

Cannot query documents without limit using multi2 #2595

EloyID opened this issue Jun 29, 2020 · 1 comment

Comments

@EloyID
Copy link
Contributor

EloyID commented Jun 29, 2020

Before we could query all the documents setting limit = 0 in our query.

Nevertheless, this line

const limit = (props.input && props.input.limit) || (options.input && options.input.limit) || options.limit || defaultInput.limit;

causes limit fallback to 20 (the default value)

const defaultInput = { limit: 20, enableTotal: true, enableCache: false, };

Is this intended to happen or just a regression ? :)

@eric-burel
Copy link
Contributor

Probably a regression.

We probably should test typeof foo.limit === "undefined", so both limit:null and limit:0 allow to bypass the limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants