Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambiguities that arose from the test cases #1164

Closed
23 tasks done
lyxal opened this issue Jun 24, 2022 · 5 comments
Closed
23 tasks done

Ambiguities that arose from the test cases #1164

lyxal opened this issue Jun 24, 2022 · 5 comments
Labels
difficulty: hard This will require a fair amount of effort. difficulty: time-consuming A tedious, time-consuming task enhancement New feature or request help wanted Extra attention is needed priority: high Issues with high priority The Great Bug Fix

Comments

@lyxal
Copy link
Member

lyxal commented Jun 24, 2022

Round 2 of everyone's favourite game. This time, the failed tests are to do with decisions regarding things like typing or edge cases that weren't previously thought of. That means that some things can be ignored/left as-is.

@lyxal lyxal added enhancement New feature or request help wanted Extra attention is needed priority: high Issues with high priority difficulty: hard This will require a fair amount of effort. difficulty: time-consuming A tedious, time-consuming task The Great Bug Fix labels Jun 24, 2022
@cgccuser cgccuser added this to the The Great Bug Fix milestone Jun 24, 2022
@lyxal
Copy link
Member Author

lyxal commented Jun 24, 2022

From Seggan:

image

image

@lyxal
Copy link
Member Author

lyxal commented Jun 24, 2022

From emanresuA:

image

@Steffan153
Copy link
Contributor

Steffan153 commented Jun 24, 2022

My opinions:

  • ½: yes: two strings means ["", ""]
  • F: yes: lhs is string, so keep a string
  • O: yes
  • V: no: should be 434 (as a number, not a string like it currently is)
  • : no: should be "a"
  • Ȧ: no: [0, 2, 2]
  • İ: no: it should treat the first list as indices: [0.1, 1.9, "0"]
  • : yes: all inputs were numbers, so keep it a number
  • : no: make them lists
  • : yes: keep it a number
  • Ż: yes: keep it a number
  • : yes
  • : no: different types should be treated differently, so ['1', '2', 1, 2]
  • Ǒ: no: those should return 0, I don't understand how -3 and 2 were calculated
    I'll do the digraphs later.

lyxal added a commit that referenced this issue Jun 25, 2022
Goes towards closing #1164
lyxal added a commit that referenced this issue Jun 25, 2022
lyxal added a commit that referenced this issue Jun 25, 2022
lyxal added a commit that referenced this issue Jun 25, 2022
lyxal added a commit that referenced this issue Jun 25, 2022
Goes towards closing #1164
lyxal added a commit that referenced this issue Jun 25, 2022
@cgccuser
Copy link
Member

cgccuser commented Jun 25, 2022

  • ½: [""] -> ["", ""] is fine. For every other input, ½ outputs a list of length 2, so why not for "" too?
  • F: ["12345",["2","4","5"]] : [1,3]. I think lhs should be converted to a list. If someone wanted the result to be a string, they can join rhs on "".
  • O: [1213121, "1"] : 0. I don't think strings should be treated the same as numbers.
  • V: "2" and 2 should not be considered the same.
  • : [12,34] : cartesian(range(12), range(34)). I think there are fewer situations where it would be useful to do the cartesian product of the digits and turn them back into numbers. On the other hand, I've needed cartesian products of ranges in the past.
  • : [123,2] : 12. Despite what I said for , here, it'd be useless to do range(123)[:2] because you could just do range(2) instead. If you have numbers as digits set, it wouldn't be useless to get the list [1,2], but I think people would usually want 12 instead. If they really do want the list [1,2], that's fine because it would get likely get implicitly converted into that list while going through a later element anyway.
  • Ż: [123,3] : 23. This should be consistent with 's behavior.
  • : ["-123"] : -123. Yes, - should be counted as part of the integer. After all, it's "integer," not "natural number."
  • : ["12",12] : ["12",1,2] or ["12",1,2,3,...,12] depending on whether you've set the R flag (btw, I dislike the character , it looks just like U)

Steffan153 pushed a commit that referenced this issue Jun 25, 2022
Steffan153 pushed a commit that referenced this issue Jun 25, 2022
Steffan153 pushed a commit that referenced this issue Jun 25, 2022
Steffan153 pushed a commit that referenced this issue Jun 25, 2022
Steffan153 pushed a commit that referenced this issue Jun 25, 2022
Steffan153 pushed a commit that referenced this issue Jun 25, 2022
Steffan153 pushed a commit that referenced this issue Jun 28, 2022
cgccuser pushed a commit that referenced this issue Jun 28, 2022
Steffan153 pushed a commit that referenced this issue Jul 2, 2022
Steffan153 pushed a commit that referenced this issue Jul 3, 2022
lyxal added a commit that referenced this issue Jul 14, 2022
lyxal added a commit that referenced this issue Jul 14, 2022
Goes towards closing #1164
lyxal added a commit that referenced this issue Jul 14, 2022
Goes towards closing #1164

`12` as a number is different from `"12"` as a string, so really, that's the behaviour it should have
lyxal added a commit that referenced this issue Jul 14, 2022
lyxal added a commit that referenced this issue Jul 14, 2022
lyxal added a commit that referenced this issue Jul 15, 2022
Goes towards closing #1164

Okay so I think that given things like `O` consider number and string the same, that should be precedence unless types should logically be different
lyxal added a commit that referenced this issue Jul 15, 2022
Goes towards closing #1164

Same justification as #1312
lyxal added a commit that referenced this issue Jul 15, 2022
lyxal added a commit that referenced this issue Jul 15, 2022
lyxal added a commit that referenced this issue Jul 15, 2022
Goes towards closing #1164

Builds on #1314
lyxal added a commit that referenced this issue Jul 15, 2022
Goes towards closing #1164

Builds on #1317
Steffan153 pushed a commit that referenced this issue Jul 15, 2022
Goes towards closing #1164

Okay so I think that given things like `O` consider number and string the same, that should be precedence unless types should logically be different
Steffan153 pushed a commit that referenced this issue Jul 15, 2022
Goes towards closing #1164

Same justification as #1312
Steffan153 pushed a commit that referenced this issue Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: hard This will require a fair amount of effort. difficulty: time-consuming A tedious, time-consuming task enhancement New feature or request help wanted Extra attention is needed priority: high Issues with high priority The Great Bug Fix
Projects
None yet
Development

No branches or pull requests

4 participants