-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ambiguities that arose from the test cases #1164
Labels
difficulty: hard
This will require a fair amount of effort.
difficulty: time-consuming
A tedious, time-consuming task
enhancement
New feature or request
help wanted
Extra attention is needed
priority: high
Issues with high priority
The Great Bug Fix
Milestone
Comments
lyxal
added
enhancement
New feature or request
help wanted
Extra attention is needed
priority: high
Issues with high priority
difficulty: hard
This will require a fair amount of effort.
difficulty: time-consuming
A tedious, time-consuming task
The Great Bug Fix
labels
Jun 24, 2022
My opinions:
|
Closed
|
lyxal
added a commit
that referenced
this issue
Jul 14, 2022
Goes towards closing #1164 `12` as a number is different from `"12"` as a string, so really, that's the behaviour it should have
lyxal
added a commit
that referenced
this issue
Jul 15, 2022
Goes towards closing #1164 Okay so I think that given things like `O` consider number and string the same, that should be precedence unless types should logically be different
Steffan153
pushed a commit
that referenced
this issue
Jul 15, 2022
Goes towards closing #1164 Okay so I think that given things like `O` consider number and string the same, that should be precedence unless types should logically be different
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
difficulty: hard
This will require a fair amount of effort.
difficulty: time-consuming
A tedious, time-consuming task
enhancement
New feature or request
help wanted
Extra attention is needed
priority: high
Issues with high priority
The Great Bug Fix
Round 2 of everyone's favourite game. This time, the failed tests are to do with decisions regarding things like typing or edge cases that weren't previously thought of. That means that some things can be ignored/left as-is.
½
:[""] -> ["", ""]
(what to do with empty string?) (Improve the behaviour of½
#1168)F
:["12345",["2","4","5"]] : "13"
(should lhs be converted to list if rhs is already list?) (Improve the behaviour ofF
in regards to type handling #1169)O
:[1213121, "1"] : 4
(should string be considered same as int?) (MakeO
work when given a string and number and vice-versa #1170)U
:["1",1] : ["1",1]
(shouldSomeone forgot to format the test correctly."1"
and1
be considered equal in this context?)V
:[234,"2",4] : 234
(should"2"
and2
be considered equal in this context?) (MakeV
work properly with strings and numbers #1171)ḭ
:["a",3] : ""
(Why wouldn't it beLooks like it's valid after all["a"]
?) (Fix a test case forḭ
#1172)Ȧ
:[[], [1, 2], 2] : [2, 2]
(What even should happen here? What does assigning to an empty list do?) (Make assignment work on empty containers #1173)İ
:[[1,2,3], [-1,0.1,1.9,"0"]] : [3,1,2,1]
(That's a tricky one. What if there's a string in the index list?) (Improve the behaviour ofİ
#1298)Ṁ
:[134,1,2] : 1234
(Should the result be a list or a number? What if it was"a"
instead of2
?)Ẋ
:[12,34] : [13,14,23,24]
(Should those be numbers or lists?)Ẏ
:[123,2] : 12
(Number or list?) (MakeẎ
andŻ
leave numbers as numbers #1199)Ż
:[123,3] : 23
(Same as above) (MakeẎ
andŻ
leave numbers as numbers #1199)⌊
:["-123"] : -123
(Should-
be counted as part of the number?) (Make⌊
account for decimals and negatives #1198)∪
:["12",12] : ["1","2"]
(How should strings and numbers interplay here?) (Make the tests for∪
account for different types #1299)Ǒ
:[1.125, 2] : -3
and[1.125, 3] : 2
(What rules for divisibility did you use? /srs is there a way of determining decimal divisibility?)I think integer order is fine here. (Change the tests forǑ
to account for normal integer rules #1301)øḞ
:["234",2,4] : "234"
(Depends on how strings + numbers should interact)current behaviour is fine. (Change some tests forøḞ
#1312)øṄ
:[234,"2",4,1]
(Same as above)same as above (Change some tests forøṄ
#1313)ÞS
:[123] : [1,12,2,123,23,3]
(Lists or numbers?) (MakeÞS
respect original type #1297)Þ∨
:[1234,"13"] : [2,4]
(yet another query about type interaction)It needed some attention anyway (Improve the behaviour ofÞ∨
#1314)Þ∩
: (will be the same as above) (Improve the behaviour ofÞ∩
#1316)Þ∪
: (this one too) (Improve the behaviour ofÞ∪
#1317)Þ⊍
: (and this one) (Change the tests forÞ⊍
#1318)ÞK
:[123456] : [123456, 23456, 3456, 456, 56, 6]
(should those be numbers or lists?) (MakeÞK
respect original type if numeric #1303)The text was updated successfully, but these errors were encountered: