Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the behaviour of ½ #1168

Merged
merged 3 commits into from Jun 27, 2022
Merged

Improve the behaviour of ½ #1168

merged 3 commits into from Jun 27, 2022

Conversation

lyxal
Copy link
Member

@lyxal lyxal commented Jun 25, 2022

Goes towards closing #1164

@lyxal lyxal added PR: Enhancement PR only tag - for enhancements The Great Bug Fix labels Jun 25, 2022
@lyxal lyxal changed the title Improve the behaviour of ½ Improve the behaviour of ½ Jun 25, 2022
@lyxal lyxal mentioned this pull request Jun 25, 2022
Closed
23 tasks
@lyxal lyxal force-pushed the improve-the-behaviour-of-½ branch from b4a66eb to ed7a0f1 Compare June 25, 2022 14:55
@cgccuser
Copy link
Member

I have to say, it feels weird that ½ isn't the same as 2 /. We may want to rethink the behavior of /. I guess it can't be changed now because it'd be breaking, but we should take a look at it again for v3.

@lyxal lyxal force-pushed the improve-the-behaviour-of-½ branch from 937ea6c to 0786794 Compare June 26, 2022 05:22
chunkybanana
chunkybanana approved these changes Jun 26, 2022
View reviewed changes
Copy link
Member

@chunkybanana chunkybanana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ is still sus tho

@chunkybanana chunkybanana merged commit ce30ae0 into main Jun 27, 2022
@chunkybanana chunkybanana deleted the improve-the-behaviour-of-½ branch June 27, 2022 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgccuser cgccuser cgccuser left review comments

@Steffan153 Steffan153 Steffan153 approved these changes

@chunkybanana chunkybanana chunkybanana approved these changes

Assignees
No one assigned
Labels
PR: Enhancement PR only tag - for enhancements The Great Bug Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lyxal @cgccuser @Steffan153 @chunkybanana