Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS paper #1055

Closed
wants to merge 2 commits into from
Closed

JOSS paper #1055

wants to merge 2 commits into from

Conversation

akeeste
Copy link
Contributor

@akeeste akeeste commented May 17, 2023

JOSS criteria:

  • Title
  • Tags
  • Author list. @kmruehl please review, perhaps depends on whether this is viewed holistically over 10+ years or e.g. from v5.0 vs v4.0. I'm not sure what JOSS wants, but may be holistically
  • Affiliations
  • Summary. Using WEC-Sim boilerplate
  • Statement of need (including problems WEC-Sim addresses, target users, software alternatives, state of the field). @kmruehl Can you comment on historical needs that sparked the creation of WEC-Sim?
  • Recent projects/publications utilizing WEC-Sim. Easy way to reference PRIMRE SP or TE publications en masse?
  • References. Could include prior WS publications, other theory references, etc

JOSS guidelines: https://joss.readthedocs.io/en/latest/submitting.html#submission-requirements

@akeeste akeeste added the Documentation related to docs label May 17, 2023
@akeeste akeeste requested a review from kmruehl May 17, 2023 20:19
@kmruehl kmruehl self-assigned this May 31, 2023
@kmruehl kmruehl requested review from dav-og and removed request for kmruehl January 31, 2024 15:32
@kmruehl kmruehl assigned dav-og and unassigned kmruehl Jan 31, 2024
@dforbush2
Copy link
Contributor

dforbush2 commented Mar 13, 2024

WEC-Sim library depends on binary source files (e.g. *slx) where the code is not visible. JOSS does not allow submissions that include binary source files. Can we re-save the *slx as a readable source and reconsider submission? Closing for now we can reconsider later.

From Dave's correspondence:
"We were asked if the WEC-Sim software, as stored on GitHub in https://github.com/WEC-Sim/, could be published
in JOSS, given that it is Matlab code that utilizes Simulink, Simscape, and Simscape Multibody components, saved
as .slx binary files. The answer is no, this is not open-source software. The .m files are open source and JOSS has
published Matlab projects in the past. However, the problem arises in the .slx binary files, which are not open
source per the OSI definition (https://opensource.org/osd/), as they are not source code. If they were, they would
also need to have an OSI-approved license (https://opensource.org/licenses/). The fact that these are part of the
software package makes this software ineligible for JOSS review and publication."

@dforbush2 dforbush2 closed this Mar 13, 2024
@reos-rcrozier
Copy link

One solution: write matlab code file(s) which generates the .slx files.

@kmruehl
Copy link
Contributor

kmruehl commented Mar 22, 2024

Thanks for reaching out to JOSS. In the past we saved our library's *.slx files as *.mdl, which allowed them to be opened like a text file. MDL files appear to be be incompatible with newer versions of MATLAB, more info here. I'm going to re-open this issue as a motivation to explore solutions.

Update: I was able to export the WEC-Sim_Lib.slx as WEC-Sim_Lib.mdl, which can be opened with any text editor. We used this format for a while ago to allows us to better track revisions to the library, but the files are much larger the *.slx files, so we stopped used this format.
WECSim_Lib.zip

@kmruehl kmruehl reopened this Mar 22, 2024
@dav-og dav-og removed their assignment May 29, 2024
@dav-og dav-og removed their request for review May 29, 2024 14:23
@kmruehl kmruehl closed this Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation related to docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants