-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable WEC-Sim to use MoorDyn v2 capabilities #1212
Conversation
The MoorDynCaller block programatically adds and removes the From and Goto blocks according to the number of MoorDyn connections specified. I tried to arrange the model automatically but it seemed to give errors when doing it from the mask. I could also change the location of these placements, but it does not affect the functionality so I didn't feel it was worth it. |
Hey @dav-og, do you have any other comments or suggestions? Or is it ready to be merged? |
Hi @jtgrasb it seems to be running fine, I just have a couple of points:
|
@dav-og For your second question, no this is not backwards compatible with MD V1. Function names have changes, as well as input file structure, and I/O between MoorDyn and the calling script (WECSim in this case). However MD V1 is no longer in development and V2 has improved a lot of the behavior of the code, and from the MoorDyn side we encourage all users to use the most up-to-date version of v2. |
@RyanDavies19 cheers, I assumed so from MoorDyn side, but wasn't sure if on the WEC-Sim side we'd be able to do |
@dav-og Thats a good point, hopefully with the MD docs site it should be relatively simple (but potentially tedious) to convert from a v1 input file to a v2 input file. The format of both the v1 and the v2 input files are in there. |
Noting that @jtgrasb and I discussed the pending reviews above and they can be closed |
@dav-og Thanks for the review.
|
Looks like there is a persistent offset in the v2 results, but it probably makes sense to trust the v2 results more. @RyanDavies19 is there a verification reference for v2 that we can point to in our docs? |
@dav-og for now point to here: https://moordyn.readthedocs.io/en/latest/theory.html#id2 I am working on adding more v2 theory papers to that site. In general, for the past couple years work using MoorDyn-C and/or MoorDyn-F in OpenFAST have been using MoorDyn v2. Here are some other references I will add to the MD docs site: https://www.nrel.gov/docs/fy23osti/83342.pdf |
Thanks @RyanDavies19 and @dav-og. The documentation added here points to the updated MoorDyn Documentation. |
ready to merge 👍 |
This PR expands upon #1134 to enable WEC-Sim's use of MoorDyn's new capabilities, notably the ability to handle mooring lines between multiple dynamic bodies. This PR includes the following changes:
MoorDynConnection
block, which has two connections to detect the relative motion between two bodies/frames, send the displacement and velocity to theMoorDynCaller
block, and receive back the forces calculates by MoorDynMoorDynCaller
block that programmatically receives the displacement and velocity from theMoorDynConnection
block(s) and calls MoorDyn to calculate the forces.MoorDynCaller
block, but it allows for multiple connection blocks to be used.A few other notes about the implementation:
[0, 0, 0]
so that the motion passed into MoorDyn is the exact motion of the body.