Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MoorDyn and Paraview examples to be compatible with new MoorDyn v2 format #57

Merged
merged 14 commits into from
May 29, 2024

Conversation

jtgrasb
Copy link
Contributor

@jtgrasb jtgrasb commented Jan 30, 2024

This PR goes along with WEC-Sim PR#1212 to update the RM3 MoorDyn examples to be compatible with the new v2 capabilities and format. This includes updating both the Mooring/MoorDyn example and the Paraview_Visualization\RM3_MoorDyn_Viz example.

@H0R5E
Copy link
Contributor

H0R5E commented Feb 14, 2024

@jtgrasb, I added the Mooring folder into the Windows tests today, which is why this PR is failing now. I tried to merge in the changes on the dev branch, but that didn't help (maybe made it worse?).

The errors it's throwing are:

Failed to find 'WECSim_Lib_Moorings/MoorDynCaller' in library 'WECSim_Lib_Moorings' referenced by 'RM3MoorDyn/MoorDynCaller'
Failed to find 'WECSim_Lib_Moorings/MoorDynConnection' in library 'WECSim_Lib_Moorings' referenced by 'RM3MoorDyn/MoorDynConnection'

The test is working on the dev branch, so I'm not sure what has happened here, Sorry.

@jtgrasb
Copy link
Contributor Author

jtgrasb commented Feb 21, 2024

@H0R5E Thanks for adding the MoorDyn folder to the tests. This PR goes along with some updates to the Mooring Library in WEC-Sim which aren't merged yet, so it is expected that the mooring tests will fail until that PR is merged into dev

@H0R5E
Copy link
Contributor

H0R5E commented Feb 22, 2024

@jtgrasb

it is expected that the mooring tests will fail until that PR is merged into dev

Thanks for the heads up!

@jtgrasb
Copy link
Contributor Author

jtgrasb commented Mar 20, 2024

@dav-og I've attached a zip file with the results from the old version. You can use it to compare to the new version.

As for the testing, the tests are already set up to load in the MoorDyn repository to run the applications case. One thing that will need to be addressed at some point is the operating system we test it on (MD has different files for windows, linux, and mac), but I think this can be revisited with all the rest of the tests.

WS+MDv1_res.zip

@dav-og
Copy link
Contributor

dav-og commented Mar 20, 2024

Awesome! Thanks Jeff! 👍

@jtgrasb jtgrasb merged commit a7dbd2f into WEC-Sim:dev May 29, 2024
45 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants