-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error handling for layers #27
Comments
Linked to #7 |
Redux state now has an errors array in MapState (and an error string for table state and server dates). We should probably just add a snackbar to display any errors. This could potentially be implemented using a Redux middleware too. |
@laveesh and I are looking into implementing one of the two react notification APIs Creating the notification will be pretty easy - just a function call. We could do this two ways:
Which do you think is better for the long run? |
This is to solve issue WFP-VAM#27
Update: After some discussion with @laveesh, we've decided to use Material UI's built in Snackbar. We also will be taking approach 1 to make things more stable in the long run (and as @bencpeters suggested). Look out for a PR! |
Handle errors when fetching data.
In particular, have the ability to parse time mismatch "Time dimension value '2020-02-10' not valid for this layer".
And server errors (eg. server offline)
The text was updated successfully, but these errors were encountered: