Use selected startDate in layer query #25
Conversation
ericboucher
changed the title
| @@ -6,10 +6,16 @@ import DateSelector from '.'; | |||
| import { store } from '../../../context/store'; | |||
|
|
|||
| test('renders as expected', () => { | |||
| const realDateNow = Date.now.bind(global.Date); | |||
There was a problem hiding this comment.
I was thinking about mocking the whole store
This shouldn't be a problem anymore because the initial values of dates are number
There was a problem hiding this comment.
This is a problem because the maxDate keeps changing
| @@ -27,6 +27,9 @@ import { | |||
| import { months, getMonthStartAndEnd, isAvailableMonth } from './utils'; | |||
| import { AvailableDates } from '../../../config/types'; | |||
|
|
|||
| // Set default timezone to UTC | |||
There was a problem hiding this comment.
Do it make sense to set that in src/components/App/index.tsx?
There was a problem hiding this comment.
Let's have you play around with that when fixing #30
| @@ -17,10 +17,12 @@ const Map = ReactMapboxGl({ | |||
| function MapView({ classes }: MapViewProps) { | |||
| const layers = useSelector(layersSelector); | |||
| const serverAvailableDates = useSelector(availableDatesSelector); | |||
| const selectedLayersDates = serverAvailableDates.filter((dates, layerId) => | |||
| layers.has(layerId), | |||
| const selectedLayersDates = serverAvailableDates.filter((_, layerId) => | |||
There was a problem hiding this comment.
For example in src/config/layers.json:
"ndvi": {
"title": "Modis NDVI",
"server_type": "wms",
--> "server_layer": "ModisIndices",
"server_uri": "http://185.30.8.6:5000/wms?styles=ndvi&layers=ModisIndices",
"has_date": true,
"date_interval": "month",
"opacity": 0.3,
"legend_text": "Modis NDVI"
},
The layerId is ndvi and server_layer is ModisIndices.
I will keep layers.has(layerId) 🤔?
There was a problem hiding this comment.
The names from the server and the layerId are not the same. We can discuss that if thtat's not clear but I will likely change a few things in #29
ericboucher
force-pushed
the
wms-get-date
branch
from
5c7f17e
to
f0b57ba
Compare
ericboucher
force-pushed
the
manage-dates
branch
from
47ab01a
to
4dec5b7
Compare
mamadOuologuem
force-pushed
the
wms-get-date
branch
from
f0b57ba
to
4a1bfc2
Compare
ericboucher
force-pushed
the
manage-dates
branch
from
63cb4f7
to
6965b15
Compare
Use startDate info in the layer query.
This surfaced a few issues/needs:
need for a better definition of layers. We could probably get rid of the path and use a config for servers, then a server_layer_id and server_style. (Improve config definition for servers and layers #29 )
For now, we should only be able to select one layer that has dates at a time. (Limit to one "has_date" layer at a time #28 )
handle errors when fetching data. In particular, have the ability to parse time mismatch "Time dimension value '2020-02-10' not valid for this layer". (Error handling for layers #27 )
We are currently getting the "Time dimension value '2020-02-10' not valid for this layer" because of a timezone difference which creates a one-day diff. 2020-02-11 is available. We should indicate the timezone in the server definition. (Fixed by adding a moment default timezone)