Skip to content

Commit

Permalink
feat(Icons): Upgrade to newer version, console.logs removed
Browse files Browse the repository at this point in the history
  • Loading branch information
Utzel-Butzel committed Feb 19, 2019
1 parent 80a657f commit 0fb1fe3
Show file tree
Hide file tree
Showing 14 changed files with 11 additions and 25 deletions.
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@
}
},
"peerDependencies": {
"@wfp/icons": "^0.0.71",
"@wfp/icons": "^0.0.72",
"react": "^16.4.0",
"react-dom": "^16.4.0"
},
Expand Down Expand Up @@ -154,7 +154,7 @@
"@storybook/addon-storysource": "^4.1.7",
"@storybook/addons": "^4.1.7",
"@storybook/react": "^4.1.7",
"@wfp/icons": "0.0.71",
"@wfp/icons": "0.0.72",
"add": "^2.0.6",
"all-contributors-cli": "^5.2.1",
"autoprefixer": "^8.3.0",
Expand Down Expand Up @@ -367,4 +367,4 @@
]
},
"bundleSizeThreshold": 80000
}
}
6 changes: 3 additions & 3 deletions src/components/FileUploader/FileUploader.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import settings from '../../globals/js/settings';
import Icon from '../Icon';
import uid from '../../tools/uniqueId';
import { ButtonTypes } from '../../prop-types/types';
import { iconCloseSolid, iconCheckmarkSolid } from '@wfp/icons';
import { iconCloseGlyph, iconCheckmarkGlyph } from '@wfp/icons';
import { componentsX } from '../../internal/FeatureFlags';

const { prefix } = settings;
Expand Down Expand Up @@ -229,7 +229,7 @@ export class Filename extends Component {
<Icon
description={iconDescription}
className={`${prefix}--file-close`}
icon={iconCloseSolid}
icon={iconCloseGlyph}
style={style}
{...other}
/>
Expand All @@ -239,7 +239,7 @@ export class Filename extends Component {
<Icon
description={iconDescription}
className={`${prefix}--file-complete`}
icon={iconCheckmarkSolid}
icon={iconCheckmarkGlyph}
style={style}
{...other}
/>
Expand Down
1 change: 1 addition & 0 deletions src/components/FileUploader/README.md
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@

FileUploader
1 change: 0 additions & 1 deletion src/components/Modal/ModalWithControls-story.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ class ModalWithControls extends React.Component {
state = { open: false };

toggleModal = () => {
console.log('Toggle the open state');
this.setState(state => ({
open: !state.open,
}));
Expand Down
1 change: 0 additions & 1 deletion src/components/ReadMore/ReadMore.js
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,6 @@ export default class ReadMore extends Component {
display: 'block',
};

console.log('sss', collapseLink, expandLink);
return (
<div className={classNames}>
<div className={`${prefix}--read-more__content`} style={contentStyle}>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ const props = {
};

const renderAnchor = props => {
console.log(props);
return <a href={props.href}>{props.label}</a>;
};

Expand Down
1 change: 0 additions & 1 deletion src/components/StepNavigation/StepNavigation-story.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ const props = {
};

const handleTabClick = index => {
console.log('click', index);
this.setState({ page: index });
};

Expand Down
1 change: 0 additions & 1 deletion src/components/StepNavigation/StepNavigation.js
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,6 @@ export default class StepNavigation extends React.Component {

// following functions (handle*) are Props on Tab.js, see Tab.js for parameters
handleTabClick = onSelectionChange => {
console.log('Handle tabl click');
return (index, label, evt) => {
evt.preventDefault();
this.selectTabAt(index, onSelectionChange);
Expand Down
1 change: 0 additions & 1 deletion src/components/Tab/Tab.js
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@ export default class Tab extends React.Component {
tabIndex: -1,
className: classes,
onClick: evt => {
console.log('click');
handleTabClick(index, label, evt);
onClick(evt);
},
Expand Down
1 change: 0 additions & 1 deletion src/documentation/HtmlComponent.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import React from 'react';
import Wrapper from '../components/Wrapper';

const SingleComponent = ({ children, html, pageWidth }) => {
console.log(children);
return (
<Wrapper
style={{
Expand Down
1 change: 0 additions & 1 deletion src/documentation/Logos-story.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ const LogoElement = ({ color, logoKind, src }) => {
logoKind === 'standard' || logoKind === 'extended' ? 'auto' : 'auto';
const height =
logoKind === 'standard' || logoKind === 'extended' ? '40px' : '80px';
console.log(process.env);
return (
<div style={{ display: 'inline-block', marginRight: '10px' }}>
<div
Expand Down
7 changes: 1 addition & 6 deletions src/documentation/WizardForm/WizardForm.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,18 +33,13 @@ class WizardForm extends Component {
}

handleTabClick = index => {
console.log('click', index);
this.setState({ page: index });
};

render() {
const { error, onSubmit } = this.props;
const { onSubmit } = this.props;
const { page } = this.state;

/* const validation = validate(this.props.values, this.props);
console.log("validation", validation, this.props.values); */

return (
<Wrapper pageWidth="md" spacing="xl">
<FormWizard
Expand Down
2 changes: 0 additions & 2 deletions src/documentation/WizardForm/validateSecondPage.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { formErrorResponse, isRequired } from '../../components/FormError';

const validate = (values, formData) => {
console.log('Values', formData, values);
const errors = {};
//errors.firstName = isRequired(values.firstName);
//errors.email = isRequired(values.email);
Expand Down Expand Up @@ -29,7 +28,6 @@ const validate = (values, formData) => {
errors._error = 'No way';
}

console.log('errors', errors, Object.keys(errors).length);
return formErrorResponse(errors);
};

Expand Down
6 changes: 3 additions & 3 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2168,9 +2168,9 @@
"@webassemblyjs/wast-parser" "1.7.11"
"@xtuc/long" "4.2.1"

"@wfp/icons@0.0.71":
version "0.0.71"
resolved "https://registry.yarnpkg.com/@wfp/icons/-/icons-0.0.71.tgz#5af5d046c3f39312d57d363debc0bd5accca7c84"
"@wfp/icons@0.0.72":
version "0.0.72"
resolved "https://registry.yarnpkg.com/@wfp/icons/-/icons-0.0.72.tgz#e1a5c80ad0960a64b17bd02b6f3c5fce8a4ac44f"

"@xtuc/ieee754@^1.2.0":
version "1.2.0"
Expand Down

0 comments on commit 0fb1fe3

Please sign in to comment.